Non-recursive directory copy incorrect

[ianthomas23]

A non-recursive directory copy, which is a slightly silly thing to attempt but is supported, gives the wrong result.

cp("source/somedir/", "target/", recursive=False)

creates an empty directory target/somedir. But command-line cp, which is what we are basing our behaviour on, does nothing at all here.

[martindurant]

It's not very wrong :) In fact, with the trailing "/", it does look like "put the source item INTO the target", surprised that CLI cp is a no-op.

[ianthomas23]

Command-line copy gives you

$ cp source/subdir/ target/
cp: source/subdir/ is a directory (not copied).

regardless of trailing slashes on source or target.

I agree that it is not very wrong, ours feels like better behaviour really. But I would very much like to be able to say "we follow command-line copy behaviour" and not have a single exception to this.