Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touchscreen calibration #151

Merged
merged 28 commits into from Feb 3, 2019

Conversation

@ski7777
Copy link
Member

commented Dec 9, 2018

As discussed on the convention
Closes #149

ski7777 added some commits Dec 9, 2018

@ski7777 ski7777 added the enhancement label Dec 9, 2018

@ski7777 ski7777 added this to the V1.0 milestone Dec 9, 2018

@ski7777 ski7777 added this to In progress in Roadmap via automation Dec 9, 2018

@ski7777 ski7777 requested review from rkunze and PeterDHabermehl Dec 9, 2018

@ski7777 ski7777 moved this from In progress to Needs review in Roadmap Dec 9, 2018

@ski7777

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2018

I will test this in detail tomorrow

@ski7777

This comment has been minimized.

Copy link
Member Author

commented Dec 11, 2018

I just tested it. There were two little mistakes. I tried the automatic reset feature on boot. It works and the save calibration works, too 👍

@ski7777

This comment has been minimized.

Copy link
Member Author

commented Feb 3, 2019

Would be really nice if someone could review this. I will upload a test build including this later.

@rkunze

This comment has been minimized.

Copy link
Member

commented Feb 3, 2019

Would be really nice if someone could review this.

I thought I already did that back in December, but it seems that review did not get through. I'll do it now.

@ski7777

This comment has been minimized.

Copy link
Member Author

commented Feb 3, 2019

This is a quick and dirty build from my devel branch: https://github.com/ski7777/ftcommunity-TXT/releases/tag/v0.9.5-dev.snapshot-20190203

rkunze and others added some commits Feb 3, 2019

Update board/fischertechnik/TXT/rootfs/opt/ftc/apps/system/display/di…
…splay_de.ts


Fix typo

Co-Authored-By: ski7777 <r.jacob2002@gmail.com>
Revert "Allow ftc to unset flag"
This reverts commit fb7af82.
Revert "Allow ftc to set flag"
This reverts commit 92c5ae5.

ski7777 added some commits Feb 3, 2019

@rkunze
Copy link
Member

left a comment

In addition to the review comments, please also

  • drop the superfluous set/reset scripts (that is really the whole purpose of this series of changes) and
  • change /etc/sudoers.d/display-settings to allow /usr/sbin/calibrate-touchscreen instead of plain /usr/bin/ts_calibrate for the ftc user (this is needed so you can move the sudo call outside the calibrate-touchscreen script).

rkunze and others added some commits Feb 3, 2019

Update board/fischertechnik/TXT/rootfs/etc/init.d/S80touchscreen-cali…
…bration

Co-Authored-By: ski7777 <r.jacob2002@gmail.com>
Merge branch 'touchscreen-calibration' of github.com:ftCommunity/ftco…
…mmunity-TXT into touchscreen-calibration
@ski7777

This comment has been minimized.

Copy link
Member Author

commented Feb 3, 2019

When this is finished, we need to squash this hell of commits

Roadmap automation moved this from Needs review to Reviewer approved Feb 3, 2019

@rkunze

rkunze approved these changes Feb 3, 2019

Copy link
Member

left a comment

Other than the last change to /etc/sudoers.d/touchscreen-calibration: Looks good to me.

@rkunze

This comment has been minimized.

Copy link
Member

commented Feb 3, 2019

When this is finished, we need to squash this hell of commits

if you don't want to keep them for posterity 😁

@ski7777

This comment has been minimized.

Copy link
Member Author

commented Feb 3, 2019

Looks like everything is done

@ski7777 ski7777 requested a review from rkunze Feb 3, 2019

@ski7777 ski7777 moved this from Reviewer approved to Needs review in Roadmap Feb 3, 2019

@rkunze rkunze closed this Feb 3, 2019

Roadmap automation moved this from Needs review to Done Feb 3, 2019

@rkunze rkunze reopened this Feb 3, 2019

Roadmap automation moved this from Done to In progress Feb 3, 2019

@rkunze rkunze merged commit cbac612 into master Feb 3, 2019

Roadmap automation moved this from In progress to Done Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.