Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx route returns empty gif #6

Closed
manuelmeurer opened this issue Sep 1, 2014 · 3 comments
Closed

Nginx route returns empty gif #6

manuelmeurer opened this issue Sep 1, 2014 · 3 comments

Comments

@manuelmeurer
Copy link
Contributor

The nginx config file contains this route:

location ~ /_.gif {
    empty_gif;
}

What is the purpose of this?
I was thinking about adding the .gif extensions to my counting calls but they don't get through to voncount.lua since they are picked up by the route above.

@Ronsho
Copy link

Ronsho commented Sep 2, 2014

Hey!
We are executing this route at the end of the counting operation so each request to count-von-count automatically returns an empty gif.

On the last line of voncount.lua, we trigger utils:emptyGif() which executes this route.

@manuelmeurer
Copy link
Contributor Author

Ah yes, I overlooked that. I will change the route to /empty.gif in my fork, so that I can add the .gif extension to my tracking calls. Would you be interested in a PR?

@manuelmeurer
Copy link
Contributor Author

I implemented this here: https://github.com/krautcomputing/count-von-count/commit/c3efe7319dc86c3fcf7718c45f4d7af109723c57
Feel free to cherry-pick or plain copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants