Fix: assert_has input by value should not fail if multiple nodes match (#73)

Author: ftes

CHANGELOG.md

@@ -6,9 +6,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## tbd
+### Fixed
+- `assert_has/refute_has`: don't raise if multiple nodes found when using `value` option (playwright strict mode)
 ### Changed
 - Return result tuples from all playwright channel functions for consistency and to surface errors early.
   - Most notably may affect callers of `Frame.evaluate/3`
+### Added
+- Config option `selector_engines`.
 
 ## [0.8.0] 2025-09-17
 ### Removed

lib/phoenix_test/playwright.ex

@@ -636,25 +636,19 @@ defmodule PhoenixTest.Playwright do
       |> Selector.and(Selector.label(opts[:label], exact: true))
       |> Selector.concat("visible=true")
       |> Selector.concat(Selector.text(opts[:text], opts))
-
-    at = &(selector |> Selector.concat(Selector.at(&1)) |> Selector.build())
+      |> Selector.concat(Selector.value(opts[:value]))
 
     params =
       case Map.new(opts) do
-        %{value: _, count: _} ->
-          raise(ArgumentError, message: "Options `value` and `count` can not be used together")
-
         %{count: _, at: _} ->
           raise(ArgumentError, message: "Options `count` and `at` can not be used together")
 
-        %{value: value} ->
-          %{expression: "to.have.value", expected_text: [%{string: value}], selector: at.(opts[:at])}
-
         %{count: count} ->
           %{expression: "to.have.count", expected_number: count, selector: Selector.build(selector)}
 
         _ ->
-          %{expression: "to.be.visible", selector: at.(opts[:at] || 0)}
+          selector = Selector.concat(selector, Selector.at(opts[:at] || 0))
+          %{expression: "to.be.visible", selector: selector}
       end
 
     params = Enum.into(params, Enum.into(other_params, %{timeout: timeout(opts)}))

lib/phoenix_test/playwright/browser_context.ex

@@ -72,4 +72,12 @@ defmodule PhoenixTest.Playwright.BrowserContext do
     |> post()
     |> Result.from_response(& &1)
   end
+
+  def register_selector_engine(context_id, name, source, opts \\ []) do
+    params = %{selector_engine: Enum.into(opts, %{name: name, source: source})}
+
+    [guid: context_id, method: :register_selector_engine, params: params]
+    |> post()
+    |> Result.from_response(& &1)
+  end
 end

lib/phoenix_test/playwright/case.ex

@@ -86,6 +86,7 @@ defmodule PhoenixTest.Playwright.Case do
       })
 
     {:ok, browser_context_id} = Playwright.Browser.new_context(context.browser_id, browser_context_opts)
+    register_selector_engines!(browser_context_id)
 
     {:ok, page_id} = Playwright.BrowserContext.new_page(browser_context_id, config[:browser_page_opts])
     {:ok, _} = Playwright.Page.update_subscription(page_id, event: :console, enabled: true)
@@ -105,6 +106,12 @@ defmodule PhoenixTest.Playwright.Case do
     })
   end
 
+  defp register_selector_engines!(browser_context_id) do
+    for {name, source} <- Playwright.Selector.Engines.custom() do
+      {:ok, _} = Playwright.BrowserContext.register_selector_engine(browser_context_id, to_string(name), source)
+    end
+  end
+
   defp trace(browser_context_id, config, context) do
     {:ok, _} = Playwright.BrowserContext.start_tracing(browser_context_id)
 

lib/phoenix_test/playwright/config.ex

@@ -99,6 +99,12 @@ schema =
       doc:
         "Additional arguments passed to Playwright [Browser.newPage](https://playwright.dev/docs/api/class-browser#browser-new-page).\n" <>
           ~s(E.g. `[accept_downloads: false]`)
+    ],
+    selector_engines: [
+      default: [],
+      type: {:or, [:map, :keyword_list]},
+      doc:
+        "Define custom Playwright [selector engines](https://playwright.dev/docs/extensibility#custom-selector-engines)."
     ]
   )
 

lib/phoenix_test/playwright/selector.ex

@@ -52,6 +52,10 @@ defmodule PhoenixTest.Playwright.Selector do
   def css(selector) when is_binary(selector), do: css([selector])
   def css(selectors) when is_list(selectors), do: "css=#{Enum.join(selectors, ",")}"
 
+  # Custom
+  def value(nil), do: :none
+  def value(value), do: "phoenix_test_value='#{value}'"
+
   defp exact_suffix(opts) when is_list(opts), do: opts |> Keyword.get(:exact, false) |> exact_suffix()
 
   defp exact_suffix(true), do: "s"

lib/phoenix_test/playwright/selector/engines.ex

@@ -0,0 +1,23 @@
+defmodule PhoenixTest.Playwright.Selector.Engines do
+  @moduledoc """
+  Custom selector engines.
+  https://playwright.dev/docs/extensibility#custom-selector-engines
+  """
+
+  @paths Path.wildcard(Path.join(__DIR__, "engines/*.js"))
+  @paths_hash :erlang.md5(@paths)
+
+  for path <- @paths do
+    @external_resource path
+  end
+
+  def __mix_recompile__? do
+    :erlang.md5(@paths) != @paths_hash
+  end
+
+  def custom do
+    from_config = PhoenixTest.Playwright.Config.global(:selector_engines)
+    default = Map.new(@paths, &{Path.basename(&1, ".js"), File.read!(&1)})
+    Enum.into(from_config, default)
+  end
+end

lib/phoenix_test/playwright/selector/engines/phoenix_test_value.js

@@ -0,0 +1,6 @@
+{
+  queryAll(root, selector) {
+    const selectorWithoutQuotes = selector.substring(1, selector.length - 1)
+    return root.value === selectorWithoutQuotes ? [root] : []
+  }
+}

test/phoenix_test/playwright_test.exs

@@ -624,15 +624,13 @@ defmodule PhoenixTest.PlaywrightTest do
       |> assert_has("#pre-rendered-data-form input[name=comments]")
     end
 
-    @tag skip: "FIXME #71"
     test "succed with value option if CSS selector matches multiple nodes", %{conn: conn} do
       conn
       |> visit("/live/index")
       |> within("#owner-form", &fill_in(&1, "Name", with: "Gandalf"))
       |> assert_has("input[name=name]", value: "Gandalf")
     end
 
-    @tag skip: "FIXME #71"
     test "succeed with value option if label selector matches multiple nodes", %{conn: conn} do
       conn
       |> visit("/live/index")