New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refined-pureconfig #233

Merged
merged 4 commits into from Dec 23, 2016

Conversation

Projects
None yet
3 participants
@vlovgr
Contributor

vlovgr commented Dec 23, 2016

Adds a refined-pureconfig project containing a tiny integration with pureconfig.
I've tried to keep things as similar as possible to refined-scodec where possible.

vlovgr added some commits Dec 23, 2016

)
```
For Scala.js just replace `%%` with `%%%` above.
For Scala.js just replace `%%` with `%%%` above (except for `refined-pureconfig` which is not available for Scala.js).

This comment has been minimized.

@vlovgr

vlovgr Dec 23, 2016

Contributor

Issue for pureconfig scala.js support: pureconfig/pureconfig#46

@@ -167,7 +188,20 @@ lazy val submoduleSettings = Def.settings(
)
lazy val submoduleJvmSettings = Def.settings(
mimaPreviousArtifacts := Set(groupId %% moduleName.value % latestVersion),
mimaPreviousArtifacts := {

This comment has been minimized.

@vlovgr

vlovgr Dec 23, 2016

Contributor

I couldn't get mimaReportBinaryIssues to work without these changes. (We could potentially remove this after a release with refined-pureconfig has been issued.)

This comment has been minimized.

@fthomas

fthomas Dec 23, 2016

Owner

👍 Or if we leave it in, adding the next submodule will be easier.

@codecov-io

This comment has been minimized.

codecov-io commented Dec 23, 2016

Current coverage is 99.26% (diff: 100%)

Merging #233 into master will increase coverage by 0.01%

@@             master       #233   diff @@
==========================================
  Files            34         35     +1   
  Lines           402        408     +6   
  Methods         379        385     +6   
  Messages          0          0          
  Branches         21         21          
==========================================
+ Hits            399        405     +6   
  Misses            3          3          
  Partials          0          0          

Powered by Codecov. Last update 1b7dc98...97b3b3a

@fthomas

This comment has been minimized.

Owner

fthomas commented Dec 23, 2016

Awesome @vlovgr. Thanks for this early christmas present! :-)

@fthomas

LGTM. Thanks again, @vlovgr!

@@ -167,7 +188,20 @@ lazy val submoduleSettings = Def.settings(
)
lazy val submoduleJvmSettings = Def.settings(
mimaPreviousArtifacts := Set(groupId %% moduleName.value % latestVersion),
mimaPreviousArtifacts := {

This comment has been minimized.

@fthomas

fthomas Dec 23, 2016

Owner

👍 Or if we leave it in, adding the next submodule will be easier.

@@ -0,0 +1,4 @@
package eu.timepit.refined.pureconfig.error
final case class PredicateFailedException(message: String)

This comment has been minimized.

@fthomas

fthomas Dec 23, 2016

Owner

I was thinking about adding a special exception for refinement errors in #101 but didn't came around adding it yet to the core module. Are there any reasons against moving this later to the core module?

This comment has been minimized.

@vlovgr

vlovgr Dec 23, 2016

Contributor

Adding it to the core module sounds good, should be no reason against having it there! 👍

@fthomas fthomas merged commit 4e8c5c6 into fthomas:master Dec 23, 2016

3 checks passed

codecov/patch 100% of diff hit (target 99.25%)
Details
codecov/project 99.26% (+0.01%) compared to 1b7dc98
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vlovgr

This comment has been minimized.

Contributor

vlovgr commented Dec 23, 2016

@fthomas Thanks for reviewing and getting this merged! 👍

The repository readme now says "eu.timepit" %% "refined-pureconfig" % "0.6.0", which is not available. Any chance of a new release? 😄

@vlovgr vlovgr deleted the vlovgr:refined-pureconfig branch Dec 23, 2016

@fthomas

This comment has been minimized.

Owner

fthomas commented Dec 24, 2016

@vlovgr I fixed the README. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment