Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent updates to a pre-release of another series #1009

Merged
merged 2 commits into from Sep 30, 2019

Conversation

@fthomas
Copy link
Owner

commented Sep 30, 2019

This contains code from #851 for preventing updates to a pre-release of
another version series. Version.selectNext is now responsible for
selecting the next version from a list of possible newer versions. This
functions implements the scheme described in
https://github.com/fthomas/scala-steward/blob/master/docs/faq.md#how-does-scala-steward-decide-what-version-it-is-updating-to
and also filters out all bumps between pre-releases of different version
series. This code incidentally also makes the code to deal with updates
from non-snapshot to snapshot versions (#485) superfluous.

Closes #956.

fthomas added 2 commits Sep 30, 2019
This contains code from #851 for preventing updates to a pre-release of
another version series. Version.selectNext is now responsible for
selecting the next version from a list of possible newer versions. This
functions implements the scheme described in
https://github.com/fthomas/scala-steward/blob/master/docs/faq.md#how-does-scala-steward-decide-what-version-it-is-updating-to
and also filters out all bumps between pre-releases of different version
series. This code incidentally also makes the code to deal with updates
from non-snapshot to snapshot versions (#485) superfluous.

Closes #956.
@fthomas fthomas added the bug label Sep 30, 2019
@fthomas fthomas added this to the 0.5.0 milestone Sep 30, 2019
@fthomas fthomas merged commit 8ba0864 into master Sep 30, 2019
4 checks passed
4 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Summary no rules match, no planned actions
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@fthomas fthomas deleted the topic/no-prerelease-different-series branch Sep 30, 2019
fthomas added a commit that referenced this pull request Oct 9, 2019
With #1009 we can simplify FilterAlg.badVersions since some of the
updates prevented by it are now prevented by selectSuitableNextVersion.
fthomas added a commit that referenced this pull request Oct 9, 2019
With #1009 we can simplify FilterAlg.badVersions since some of the
updates prevented by it are now prevented by selectSuitableNextVersion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.