Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify FilterAlg.badVersions #1029

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@fthomas
Copy link
Owner

commented Oct 9, 2019

With #1009 we can simplify FilterAlg.badVersions since some of the
updates prevented by it are now prevented by selectSuitableNextVersion.

With #1009 we can simplify FilterAlg.badVersions since some of the
updates prevented by it are now prevented by selectSuitableNextVersion.
@fthomas fthomas added the enhancement label Oct 9, 2019
@fthomas fthomas added this to the 0.5.0 milestone Oct 9, 2019
@codecov

This comment has been minimized.

Copy link

commented Oct 9, 2019

Codecov Report

Merging #1029 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
- Coverage   69.11%   69.09%   -0.03%     
==========================================
  Files          88       88              
  Lines        1347     1346       -1     
  Branches       43       44       +1     
==========================================
- Hits          931      930       -1     
  Misses        416      416
Impacted Files Coverage Δ
...scala/org/scalasteward/core/update/FilterAlg.scala 57.89% <100%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f99d369...e80fcbc. Read the comment docs.

@fthomas fthomas merged commit ac35034 into master Oct 9, 2019
5 checks passed
5 checks passed
Summary no rules match, no planned actions
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 69.11%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +30.88% compared to f99d369
Details
@fthomas fthomas deleted the topic/trim-badVersions branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.