Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CHANGES as basename of possible changelog filenames #1085

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@fthomas
Copy link
Owner

fthomas commented Nov 8, 2019

CHANGES.md is used by Monix for example:
fthomas/refined-sjs-example#69

Without this, we link to RELEASES.md (which describes Monix'
release process):
softwaremill/bootzooka#206

`CHANGES.md` is used by Monix for example:
fthomas/refined-sjs-example#69

Without this, we link to `RELEASES.md` (which describes Monix'
release process):
softwaremill/bootzooka#206
@fthomas fthomas added the enhancement label Nov 8, 2019
@fthomas fthomas added this to the 0.5.0 milestone Nov 8, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #1085 into master will decrease coverage by 0.13%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1085      +/-   ##
==========================================
- Coverage   67.92%   67.79%   -0.14%     
==========================================
  Files          90       90              
  Lines        1456     1450       -6     
  Branches       33       28       -5     
==========================================
- Hits          989      983       -6     
  Misses        467      467
Impacted Files Coverage Δ
.../scala/org/scalasteward/core/vcs/VCSExtraAlg.scala 66.66% <0%> (ø) ⬆️
...main/scala/org/scalasteward/core/vcs/package.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2976b40...a90efec. Read the comment docs.

@fthomas fthomas merged commit 1564d9f into master Nov 8, 2019
6 checks passed
6 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Summary no rules match, no planned actions
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch 80% of diff hit (target 67.92%)
Details
codecov/project Absolute coverage decreased by -0.13% but relative coverage increased by +12.07% compared to 2976b40
Details
@fthomas fthomas deleted the topic/add-changes branch Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.