Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastclick breaks <select> on Chrome 53+ #497

Open
RByers opened this issue Sep 1, 2016 · 1 comment
Open

Fastclick breaks <select> on Chrome 53+ #497

RByers opened this issue Sep 1, 2016 · 1 comment

Comments

@RByers
Copy link

@RByers RByers commented Sep 1, 2016

We (chromium) fixed our spec-compliance bug that allowed JS-generated mousedown events to open <select> boxes in Chrome 53. We just realized now (as 53 is going out to Android stable) that this breaks fastlick. Of course there's no good reason to rely on FastClick on Chrome anymore, but lots of pages still do.

We're still trying to figure out if we should undo our chromium change. But separately, perhaps FastClick should stop relying on this non-standard behavior? Maybe instead just don't intercept touches that go to <select> boxes?

Even better, just do #498.

@RByers RByers changed the title Fastclick breaks <select> on Chrome 53 beta Fastclick breaks <select> on Chrome 53+ Sep 1, 2016
elie222 added a commit to elie222/meteor that referenced this issue Dec 30, 2016
See here:
ftlabs/fastclick#497
And here:
https://productforums.google.com/forum/#!topic/chrome/Q4Rt6d0C4Qo

I just spent hours trying to figure out why selects haven't been working on my site, and finally found out it was fastclick.
@brendanfalkowski
Copy link

@brendanfalkowski brendanfalkowski commented Feb 17, 2017

Got bitten by this today. The Browserstack fleet of devices must've just received updates past Chrome 53 because I'm suddenly seeing this issue go all the way back to Android 4.4 now.

In newer projects I stopped using Fastclick because of wider support of better touch handling, but looks like I need to start pulling it out of older projects. Heading that direction now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.