Remove built javascript from repo to avoid it getting out of date; link to Browserify CDN for built version #57

Merged
merged 3 commits into from Apr 14, 2015

Conversation

Projects
None yet
6 participants
Member

matthew-andrews commented Jan 13, 2014

As discussed here.

Also a bit of spring cleaning:

  • Updating dependencies
  • Jshinting tests (not completely fixed issues here - but mostly)
  • Updating tests to use busterjs's latest version.

DONT MERGE YET

  • I've broken bower. To be continued...
Contributor

wilsonpage commented Jan 13, 2014

I think the test suite depends on the built version. Also I think we require the standalone option for the Browserify build.

Member

matthew-andrews commented Jan 13, 2014

For the test suite I should have solved that with:
c464313

Weirdly it was coveralls that caused the failed build for this:
https://travis-ci.org/ftlabs/fruitmachine/builds/16870463

I'm not sure what you mean by standalone option?

@matthew-andrews matthew-andrews commented on the diff Jan 15, 2014

test/tests/module.destroy.js
@@ -15,6 +17,7 @@ buster.testCase('View#destroy()', {
this.view.destroy();
+ assert.called(destroy);
@matthew-andrews

matthew-andrews Jan 15, 2014

Member

This spy didn't appear to have any assertions on it.

@matthew-andrews matthew-andrews commented on the diff Jan 15, 2014

test/tests/module._setEl.js
@@ -20,7 +21,6 @@ buster.testCase('View#_setEl()', {
var apple = layout.module('apple');
var orange = layout.module('orange');
- var original = orange.el;
@matthew-andrews

matthew-andrews Jan 15, 2014

Member

This wasn't used.

@matthew-andrews matthew-andrews commented on an outdated diff Jan 15, 2014

test/tests/helpers.js
@@ -21,7 +23,7 @@ buster.testCase('fruitmachine#helpers()', {
},
"helper `initialize` should have been called": function() {
- var view = fruitmachine({
+ fruitmachine({
@matthew-andrews

matthew-andrews Jan 15, 2014

Member

Hmm this was too keen, I'll put this back.

Coverage Status

Coverage remained the same when pulling df60587 on nocompiled into 446522b on master.

Coverage Status

Coverage remained the same when pulling df60587 on nocompiled into 446522b on master.

orangemug was assigned Jan 15, 2014

Member

matthew-andrews commented Jan 15, 2014

Jamie @orangemug would you mind having a look at this?

Contributor

wilsonpage commented Jan 17, 2014

Do we still want to do this following the Bower debacle?

Member

matthew-andrews commented Jan 17, 2014

Yes but not yet. I've got it to build with some forks of the dependencies with minimal changes to them (just adding bower.jsons) with debowerify.

orangemug was unassigned by rowanbeentje Dec 2, 2014

Contributor

pornel commented Mar 31, 2015

Can we drop support for Bower?

Member

quarterto commented Apr 14, 2015

#87 :)

matthew-andrews and others added some commits Jan 15, 2014

@matthew-andrews @pornel matthew-andrews Update dependencies, update readme template, upgrade to the year 2014 0379eeb
@matthew-andrews @pornel matthew-andrews Fix one failing test (assertEquals now checking type); adding in asse…
…rt/refute where required (buster upgrade problem); fixing a couple of jshint mixed tabs and spaces errors; fixing jshint unused variable error
b73dc41
@pornel @pornel pornel Renamed module
1ec2f76

@pornel pornel added a commit that referenced this pull request Apr 14, 2015

@pornel pornel Merge pull request #57 from ftlabs/nocompiled
Remove built javascript from repo to avoid it getting out of date; link to Browserify CDN for built version
7e1f837

@pornel pornel merged commit 7e1f837 into master Apr 14, 2015

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

pornel deleted the nocompiled branch Apr 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment