Set OAuth::remote() to use \Request::forge() with cURL. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides scope for better exception handling and maintainability.
|
I tried this before and was constantly getting 404 errors, even when a 500 or 401 was being thrown - which pissed me off. Is this no longer the case? |
|
You mean you were getting them as an exception from the Request object? It could well be the case actually as I have only been catching RequestStatusException. I will investigate now. |
|
Just checked with Twitter and my package (which is what prompted this pull request - https://github.com/m4tthumphrey/fuel-api/blob/master/classes/provider/oauth/twitter.php) and a faulty access token. |
philsturgeon
pushed a commit
that referenced
this pull request
Apr 23, 2012
Set OAuth::remote() to use \Request::forge() with cURL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides scope for better exception handling and maintainability.