Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace by PHPLeague/Event ? #7

Closed
WanWizard opened this issue Sep 12, 2014 · 10 comments
Closed

Replace by PHPLeague/Event ? #7

WanWizard opened this issue Sep 12, 2014 · 10 comments
Assignees

Comments

@WanWizard
Copy link
Contributor

Which is better, and has more functionality.

https://github.com/thephpleague/event

@frankdejonge
Copy link
Contributor

I've just released version 1.0.0 of that package, it's super stable and not likely to change API wise.

@emlynwest
Copy link
Contributor

I have no problem with using league/event. Although I think that some people are already using this package.

@WanWizard
Copy link
Contributor Author

Shouldn't be an issue, we're not going to delete the repo right away, just swap foundation over to use the new package.

@sagikazarmark
Copy link

I would like to assign myself to the task. However league/event has some classes needed to be registered in the dic. Should we provide a wrapper-package (or replace the current one) with a service provider or just put it in the foundation? (I am voting for the latter)

@WanWizard
Copy link
Contributor Author

The ServiceProvider is specific to Fuel v2, so I feel a wrapper package doesn't add much, other than one more package to load. So Foundation is fine by me.

@sagikazarmark sagikazarmark self-assigned this Nov 4, 2014
@sagikazarmark
Copy link

Added in league/event with a Shutdown domain event. Not sure about it's structure yet, but I am definitely in favor of domain events.

@sagikazarmark
Copy link

@WanWizard I added new event structure in session. Are you aware of any other packages using event?

@WanWizard
Copy link
Contributor Author

Every Application object has a default event instance, which is equivalent to the v1 "fuelphp" instance, and which defines the shutdown event (used by session to write). Afaik it's not used elsewhere.

@emlynwest
Copy link
Contributor

I'd say that this issue can be closed now.

@sagikazarmark
Copy link

Agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants