Replace by PHPLeague/Event ? #7

Closed
WanWizard opened this Issue Sep 12, 2014 · 10 comments

Projects

None yet

4 participants

@WanWizard
Member

Which is better, and has more functionality.

https://github.com/thephpleague/event

@frankdejonge
Contributor

I've just released version 1.0.0 of that package, it's super stable and not likely to change API wise.

@stevewest
Member

I have no problem with using league/event. Although I think that some people are already using this package.

@WanWizard
Member

Shouldn't be an issue, we're not going to delete the repo right away, just swap foundation over to use the new package.

@sagikazarmark
Member

I would like to assign myself to the task. However league/event has some classes needed to be registered in the dic. Should we provide a wrapper-package (or replace the current one) with a service provider or just put it in the foundation? (I am voting for the latter)

@WanWizard
Member

The ServiceProvider is specific to Fuel v2, so I feel a wrapper package doesn't add much, other than one more package to load. So Foundation is fine by me.

@sagikazarmark sagikazarmark self-assigned this Nov 4, 2014
@sagikazarmark
Member

Added in league/event with a Shutdown domain event. Not sure about it's structure yet, but I am definitely in favor of domain events.

@sagikazarmark
Member

@WanWizard I added new event structure in session. Are you aware of any other packages using event?

@WanWizard
Member

Every Application object has a default event instance, which is equivalent to the v1 "fuelphp" instance, and which defines the shutdown event (used by session to write). Afaik it's not used elsewhere.

@stevewest
Member

I'd say that this issue can be closed now.

@sagikazarmark
Member

Agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment