New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace by PHPLeague/Event ? #7

Closed
WanWizard opened this Issue Sep 12, 2014 · 10 comments

Comments

Projects
None yet
4 participants
@WanWizard
Member

WanWizard commented Sep 12, 2014

Which is better, and has more functionality.

https://github.com/thephpleague/event

@frankdejonge

This comment has been minimized.

Contributor

frankdejonge commented Sep 12, 2014

I've just released version 1.0.0 of that package, it's super stable and not likely to change API wise.

@emlynwest

This comment has been minimized.

Contributor

emlynwest commented Sep 12, 2014

I have no problem with using league/event. Although I think that some people are already using this package.

@WanWizard

This comment has been minimized.

Member

WanWizard commented Sep 12, 2014

Shouldn't be an issue, we're not going to delete the repo right away, just swap foundation over to use the new package.

@sagikazarmark

This comment has been minimized.

sagikazarmark commented Nov 4, 2014

I would like to assign myself to the task. However league/event has some classes needed to be registered in the dic. Should we provide a wrapper-package (or replace the current one) with a service provider or just put it in the foundation? (I am voting for the latter)

@WanWizard

This comment has been minimized.

Member

WanWizard commented Nov 4, 2014

The ServiceProvider is specific to Fuel v2, so I feel a wrapper package doesn't add much, other than one more package to load. So Foundation is fine by me.

@sagikazarmark sagikazarmark self-assigned this Nov 4, 2014

@sagikazarmark

This comment has been minimized.

sagikazarmark commented Nov 4, 2014

Added in league/event with a Shutdown domain event. Not sure about it's structure yet, but I am definitely in favor of domain events.

@sagikazarmark

This comment has been minimized.

sagikazarmark commented Nov 4, 2014

@WanWizard I added new event structure in session. Are you aware of any other packages using event?

@WanWizard

This comment has been minimized.

Member

WanWizard commented Nov 4, 2014

Every Application object has a default event instance, which is equivalent to the v1 "fuelphp" instance, and which defines the shutdown event (used by session to write). Afaik it's not used elsewhere.

@emlynwest

This comment has been minimized.

Contributor

emlynwest commented Nov 19, 2014

I'd say that this issue can be closed now.

@sagikazarmark

This comment has been minimized.

sagikazarmark commented Dec 24, 2014

Agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment