Skip to content
This repository has been archived by the owner on Sep 3, 2024. It is now read-only.

Add ability to specify remediation doc URL for custom rules #247

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

darrendao
Copy link
Contributor

This PR is for what was discussed here #236

Please note I have added unit tests. However, I noticed that there are existing unit tests in "tf_test" that are failing (in master branch). Not sure what's the problem but it's an existing issue not related to this PR. Just want to call that out.

Copy link
Contributor

@jason-fugue jason-fugue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking this on! I think this looks great.

However, I noticed that there are existing unit tests in "tf_test" that are failing (in master branch)

This is an issue with our documentation. We use a git submodule in one of those tests, so you'll need to run git submodule update --init --recursive to check it out as well. One of our outstanding todo items is to add a contributor guide for Regula.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants