Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commented defaults from generated config #320

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

jason-fugue
Copy link
Contributor

Viper changed the way WriteConfig() works in one of their more recent releases. The default values for options are getting included in the config file, which are also being duplicated by the commented-out defaults we're adding.

This PR removes those commented-out defaults and just relies on the default Viper behavior. The one option that viper doesn't write a default for is inputs since it's built from all the unnamed args and its handled differently. I think this is an OK tradeoff since it simplifies our code.

@jason-fugue jason-fugue merged commit ce04322 into master Mar 8, 2022
@jason-fugue jason-fugue deleted the config-cleanup branch March 8, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants