Fixed #2 (windows size on win10 is wrong) #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Your fix needlessly expands the dialog height on an English version of Windows 8 and 10. I guess this issue causes only on East Asian versions of Windows. The fix should have some conditional branch to distinguish them.
|
Contributor
Author
|
Thank you for comment. |
Adjusted window size on both English version of windows and CJK version of Windows
Contributor
Author
|
Adjusted the window size in both English version Windows and Japanese version Windows. Also, since the window size has become variable with previous commit, it has also been fixed. |
Added link to GitHub issue page so that problems become easy to understand
Owner
|
It works fine. Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2.
This is not a perfect fix. However, I think that it works well in most environments.