Permalink
Commits on Nov 20, 2017
  1. Implement ProcessKeyEventObject D-Bus method for X11 Korean

    fujiwarat committed Nov 20, 2017
    Currently ibus-hangul calls ibus_engine_commit_text() during
    ibus_engine_process_key_event() but sync API dos not enable such a way:
    https://mail.gnome.org/archives/gtk-devel-list/2017-August/msg00045.html
    
    X11 does not set the right order of XEvent with async APIs:
    ibus#1713
    So we need to use sync API for X11.
    Now implement the enhanced ProcessKeyEventObject D-Bus method with
    IBusInputContextEvent class and resolves the Korean issue.
Commits on Nov 17, 2017
  1. src: Reintroduce the hex mode keybind with an environment variable

    xorgy authored and fujiwarat committed Nov 17, 2017
      This was removed by "Move emoji implementation from
      IBusEngineSimple to IBusPanel". Reintroduced here
      behind an environment variable.
    
    BUG=ibus#1961
    
    Review URL: https://codereview.appspot.com/335030043
    
    Patch from Aaron Muir Hamilton <aaron@correspondwith.me>.
Commits on Nov 16, 2017
  1. src: Add libgobject.so to LDADD for Debian libtool

    huadong authored and fujiwarat committed Nov 16, 2017
    Debian libtool ignores dependency_libs in libibus.la for dlopen modules
    so need to add libraries in LDADD explicitly.
    https://www.mail-archive.com/libtool@gnu.org/msg11616.html
    
    BUG=ibus#1952
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/334070043
    
    Patch from Danny <lesarde@gmail.com>.
Commits on Nov 9, 2017
Commits on Oct 31, 2017
  1. src: Fix GVariant leaks

    garnacho authored and fujiwarat committed Oct 31, 2017
    g_task_propagate_pointer() gives ownership of the data to the caller, so
    the GVariants handed this way must be unref'ed after the contents have
    been extracted/copied.
    
    BUG=ibus#1956
    
    Review URL: https://codereview.appspot.com/330710043
    
    Patch from Carlos Garnacho <carlosg@gnome.org>.
Commits on Oct 26, 2017
Commits on Oct 22, 2017
  1. Release 1.5.17

    fujiwarat committed Oct 22, 2017
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/332030043
  2. Update translations

    fujiwarat committed Oct 22, 2017
    Update cs.po da.po es.po fr.po hu.po ja.po nl.po pl.po sv.po
           uk.po zh_TW.po
    
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/331040043
Commits on Oct 20, 2017
  1. ui/gtk3: Increase timeout of window filter in PropertyPanel

    fujiwarat committed Oct 20, 2017
    The latest Plasma desktop takes more time to generate _NET_WORKAREA
    atom and this patch increases the timeout from 1 minute to 5 minutes
    so that PropertyPanel locate within the workarea.
    
    Review URL: https://codereview.appspot.com/336840043
Commits on Oct 19, 2017
  1. ui/gtk3: Unref Panel and Indicator when double panels run

    fujiwarat committed Oct 19, 2017
    If unref is not called properly, Panel.finalize() is not called
    and Gtk.StatusIcon won't be hidden with double panels.
    
    Review URL: https://codereview.appspot.com/329510043
Commits on Oct 11, 2017
Commits on Sep 26, 2017
  1. ui/gtk3: Unset GDK_CORE_DEVICE_EVENTS

    fujiwarat committed Sep 26, 2017
    Plasma deskop sets this variable and prevents Super-space
    and Ctrl-Shift-e when ibus-ui-gtk3 runs after the
    desktop is launched.
    Also fixed a SEGV in display.get_monitor_at_window()
    Regression from rhbz#226465
    
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/321710043
Commits on Sep 15, 2017
Commits on Sep 13, 2017
  1. ui/gtk3: Fix PropertyPanel position in workarea

    fujiwarat committed Sep 13, 2017
    gdk_screen_get_monitor_workarea() no longer return the correct area
    from "_NET_WORKAREA" atom in GTK 3.22 and now use
    gdk_monitor_get_workarea() instead.
    
    Use gdk_seat_grab() instead of deprecated gdk_device_grab().
    
    Use gtk_menu_popup_at_rect() instead of deprecated gtk_menu_popup() and
    generate a new foreign GdkWindow with mouse cursor for the Qt Window.
    
    Also fixed some deprecated APIs.
    
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/330190043
Commits on Sep 11, 2017
  1. Remove debian directory upon the Debian's request

    fujiwarat committed Sep 11, 2017
    Makefile.am is also modified to get rid of debian words.
    
    BUG=ibus#1945
    R=Shawn.P.Huang@gmail.com, osamu.aoki@gmail.com, shawn.p.huang@gmail.com
    
    Review URL: https://codereview.appspot.com/322670043
Commits on Sep 7, 2017
Commits on Sep 6, 2017
  1. client/gtk2: Do not send key events to GtkIMContextSimple

    fujiwarat committed Sep 6, 2017
    GtkIMContextSimple binds Ctrl-Shift-u but IBus clients do not now.
    
    BUG=ibus#1889
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/327290043
Commits on Sep 4, 2017
  1. bus: ibus-daemon activates ibus-portal

    fujiwarat committed Sep 4, 2017
    When ibus-daemon restarts, ibus-portal exits with on_name_lost() and
    the clients wait for portal_name_appeared() until ibus-poral restarts.
    Now the clients can connect to ibus-daemon with this way and also
    they don't have to activate ibus-portal.
    
    BUG=flatpak/flatpak#675
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/321530043
  2. test: Testing in flatpak

    alexlarsson authored and fujiwarat committed Sep 4, 2017
    Test with:
    flatpak-builder --force-clean app org.test.IBus.json
    flatpak-builder --run --nofilesystem=host app org.test.IBus.json zenity --entry
    
    BUG=flatpak/flatpak#675
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/329090043
    
    Patch from Alexander Larsson <alexl@redhat.com>.
Commits on Aug 31, 2017
  1. Support the portal in the gtk im modules

    alexlarsson authored and fujiwarat committed Aug 31, 2017
    This adds a new way to create an IbusBus, ibus_bus_new_async_client().
    This returns an object that is not guarantee to handle any calls
    that are not needed by a client, meaning CreateInputContext and
    handling the input context.
    
    If you are running in a flatpak, or if IBUS_USE_PORTAL is set, then
    instead of talking to the regular ibus bus we connect to
    org.freedesktop.portal.IBus on the session bus and use the
    limited org.freedesktop.IBus.Portal interface instead of the
    org.freedesktop.IBus interface.
    
    This allows flatpaks (or other sandbox systems) to safely use
    dbus clients (apps).
    
    BUG=flatpak/flatpak#675
    
    Review URL: https://codereview.appspot.com/328410043
    
    Patch from Alexander Larsson <alexl@redhat.com>.
Commits on Aug 30, 2017
  1. Initial version of ibus portal

    alexlarsson authored and fujiwarat committed Aug 30, 2017
    This adds a dbus service called org.freedesktop.portal.IBus on the
    session bus. It is a very limited service that only implements
    CreateInputContext and the InputContext interface (and Service.Destroy
    for lifetime access).
    
    It uses gdbus code generation for demarshalling the method calls which
    means it will verify that all arguments have the right type.
    
    Additionally all method calls to the input context object have to be
    from the client that created it, so each client is isolated.
    
    BUG=flatpak/flatpak#675
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/326350043
    
    Patch from Alexander Larsson <alexl@redhat.com>.
Commits on Aug 15, 2017
  1. Typo fix

    mariobodemann authored and fujiwarat committed Aug 15, 2017
    BUG=ibus#1939
    
    Review URL: https://codereview.appspot.com/327080043
    
    Patch from Mario Bodemann <mario.bodemann@gmail.com>.
Commits on Aug 10, 2017
  1. client/gtk2: include the scaling factor

    sfanxiang authored and fujiwarat committed Aug 10, 2017
    Scaling factor, which exists for HiDPI displays, needs to be included in
    the calculation of cursor location. This does not affect devices without
    a HiDPI display.
    
    Candidate windows would be misplaced to smaller coordinates without this
    patch.
    
    BUG=ibus#1806
    
    Review URL: https://codereview.appspot.com/328250043
    
    Patch from Xiang Fan <sfanxiang@gmail.com>.
Commits on Jul 28, 2017
  1. ui/gtk3: Fix SEGV of XKeysymToKeycode() on Wayland

    fujiwarat committed Jul 28, 2017
    BUG=rhbz#1368593
    BUG=rhbz#1446816
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/325120043
Commits on Jul 25, 2017
  1. ui/gtk3: Fix SEGV of IBusEmojier on de_DE.UTF-8

    fujiwarat committed Jul 25, 2017
    de's decimal_point is ',' instead of '.' and failed to load the
    CSS data in Gtk.CssProvider.load_from_data(), launched null
    window of emojis and finally caused a SEGV due to the null window.
    This also fixes some memory leaks.
    
    BUG=rhbz#1471079
    
    Review URL: https://codereview.appspot.com/323310043
  2. po: Replace s/annotaions/annotations/

    fujiwarat committed Jul 25, 2017
    BUG=ibus#1933
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/323330043
Commits on May 29, 2017
  1. Make all emoji dicts for fully qualified

    fujiwarat committed May 29, 2017
    Currently only emoji-en.dict enables fully qualified since it imports
    emoji-test.txt and it causes to hardly compare emojis between
    emoji-en.dict and emoji-$lang.dict when m_show_emoji_variant
    is enabled. E.g. U+1F3CC-FE0F-200D-2642-FE0F
    Now emoji-$lang.dict also import emoji-test.txt and enables
    fully qualified.
    
    R=penghuang@google.com
    
    Review URL: https://codereview.appspot.com/323860043
  2. ui/gtk3: Emojier supports Ctrl-c,v,x and Ctrl-Shift-c

    fujiwarat committed May 29, 2017
    Ctrl-[c|v|x] copy, paste, or cut the emoji annotatons.
    Ctrl-Shift-c copies the selected emoji.
    Also Ctrl-Backspace is implemented to delete an annotation word.
    Also updated ibus-emoji.7.in man page.
    
    R=penghuang@google.com
    
    Review URL: https://codereview.appspot.com/316650043
Commits on May 24, 2017
  1. engine: Add Malay and Mongolian keymaps

    fujiwarat committed May 24, 2017
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/325790043
Commits on May 22, 2017
  1. configure: Change relative paths to absolute ones

    fujiwarat committed May 22, 2017
    BUG=ibus#1926
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/322990043
Commits on May 19, 2017
  1. Fix a typo in configure.ac

    felixonmars authored and fujiwarat committed May 19, 2017
    BUG=ibus#1927
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/317640043
    
    Patch from Felix Yan <felixonmars@archlinux.org>.
Commits on May 15, 2017
  1. Release 1.5.16

    fujiwarat committed May 15, 2017
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/320550043