New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hunchentoot: lift up handler-case in acceptor-dispatch-request #152

Merged
merged 1 commit into from Jun 12, 2018

Conversation

Projects
None yet
3 participants
@dkochmanski
Contributor

dkochmanski commented Jun 12, 2018

Method binds hunchentoot:catch-errors-p to NIL, so hunchentoot tries to invoke
a debugger if a condition comes to it. Error condition wasn't handled by clack
if it happened in handle-response, because handler-case was wrapped around
funcall, not the whole expression.

HANDLE-RESPONSE might have raisen an exception from SSL library (and other
communication methods) for instance when peer has closed the connection - that
lead to uncought closed stream error condition. Fixes #127.

hunchentoot: lift up handler-case in acceptor-dispatch-request
Method binds hunchentoot:*catch-errors-p* to NIL, so hunchentoot tries to invoke
a debugger if a condition comes to it. Error condition wasn't handled by clack
if it happened in handle-response, because handler-case was wrapped around
funcall, not the whole expression.

HANDLE-RESPONSE might have raisen an exception from SSL library (and other
communication methods) for instance when peer has closed the connection - that
lead to uncought closed stream error condition. Fixes #127.
@coveralls

This comment has been minimized.

coveralls commented Jun 12, 2018

Coverage Status

Coverage decreased (-0.08%) to 89.431% when pulling de4cf24 on dkochmanski:master into ac7f785 on fukamachi:master.

@fukamachi fukamachi merged commit f31eba7 into fukamachi:master Jun 12, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@fukamachi

This comment has been minimized.

Owner

fukamachi commented Jun 12, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment