Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for ipv6 domains that are too long #34

Merged

Conversation

fisxoj
Copy link
Contributor

@fisxoj fisxoj commented May 22, 2020

Hello,

I was working on another project that was using quri to validate ip addresses that had an independently maintained test suite and the ipv6 validation failed. It turns out quri only checks ipv6 addresses are valid up to the first 8 segments and doesn't care if there are more.

This makes it return nil if there are more than 8 segments (if I understand the function correctly, it's very optimized).

@coveralls
Copy link

@coveralls coveralls commented May 22, 2020

Coverage Status

Coverage decreased (-0.6%) to 68.379% when pulling 2192cfc on fisxoj:bugfix/ipv6-with-additional-segments into b53231c on fukamachi:master.

@fukamachi fukamachi merged commit b39ec54 into fukamachi:master May 27, 2020
@fukamachi
Copy link
Owner

@fukamachi fukamachi commented May 27, 2020

Thanks!

@fisxoj fisxoj deleted the bugfix/ipv6-with-additional-segments branch May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants