Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bushido Integration #97

Closed
wants to merge 21 commits into
from

Conversation

Projects
None yet
4 participants

sgrove commented Feb 24, 2012

We just added some non-invasive additions that integrate Fulcrum with Bushido's SSO/Event-hook system. If the app isn't booted on Bushido, it should function completely normally. If it's on Bushido, it'll detect at boot and enable all the Bushido-niceties :)

With this change, we're able to instantly launch Fulcrum on Bushido with one-click and have full team-awareness and basic app-interop. Here's a video demoing what it looks like: http://dl.dropbox.com/u/412963/bushido/bushido_public_video_1.mov

It also has a nice page here http://osr.gobushido.com/projects/fulcrum - the author is listed as 'Bushido' because of the git source url.

Obviously we'd prefer to have this in Fulcrum master so it doesn't fall behind, and given its non-invasive nature, it should (hopefully) be very simple.

Please let me know if we can get this merged in sooner rather than later! Thank you! And thank you for Fulcrum!

sgrove commented Mar 17, 2012

Any chance to get this reviewed?

Contributor

malclocke commented Mar 17, 2012

Hi Sean,

I've reviewed it, but if I'm honest I was trying to work out how to tactfully frame my reply. It's really great to see Fulcrum on Bushido, and I appreciate all the work you have put into this, but I still feel this is too intrusive into the code base. The database additions in particular.

I'm wondering if there is any way we could maintain a Bushido branch incorporating your changes? I'm likely to start making stable point releases in the near future once Fulcrum moves out of alpha state, perhaps maintaining a branch against the point releases would be a good compromise.

Sorry to be so negative :(

sgrove commented Mar 17, 2012

No problem at all, I'd prefer to get this into master so it's always up to
date, but I want to make sure we do it in a way that makes sense. Are you
up for a skype call to chat about it? For us, the sooner the better.

On Sat, Mar 17, 2012 at 3:05 AM, Malcolm Locke <
reply@reply.github.com

wrote:

Hi Sean,

I've reviewed it, but if I'm honest I was trying to work out how to
tactfully frame my reply. It's really great to see Fulcrum on Bushido, and
I appreciate all the work you have put into this, but I still feel this is
too intrusive into the code base. The database additions in particular.

I'm wondering if there is any way we could maintain a Bushido branch
incorporating your changes? I'm likely to start making stable point
releases in the near future once Fulcrum moves out of alpha state, perhaps
maintaining a branch against the point releases would be a good compromise.

Sorry to be so negative :(


Reply to this email directly or view it on GitHub:
malclocke#97 (comment)

Contributor

parndt commented Nov 29, 2012

I agree, this seems like wayyyy too much bushdio specific code..

Contributor

malclocke commented Jan 15, 2014

Closing as Bushido doesn't appear to exist anymore.

@malclocke malclocke closed this Jan 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment