New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alpha3] resourceRender hook can't manipulate event container #481

Open
arshaw opened this Issue Dec 21, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@arshaw
Copy link
Member

arshaw commented Dec 21, 2018

The resourceRender hook offered a bodyTds argument that allowed you to modify this part of the DOM:

screen shot 2018-12-21 at 6 02 29 pm

AND

screen shot 2018-12-21 at 6 06 27 pm

However, this is no longer available. This element is no longer given to the resourceRender handler because this part of the DOM and the resource's text (and potentially columns) are rendered separately and one might rerender while the other stays the same. If the resourceRender callback fired/refired when either of them needed to rerender, we might end up with duplicate handlers being attached.

Not sure what the best solution is. Maybe offer a separate hook for manipulating this area?

@arshaw arshaw added the Confirmed label Dec 21, 2018

@arshaw arshaw added this to the v4 milestone Dec 21, 2018

@arshaw arshaw changed the title [v4-alpha.3][regression] resourceRender hook can't manipulate event container [alpha3] resourceRender hook can't manipulate event container Dec 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment