New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical Resource View #5

Closed
philipstratford opened this Issue Aug 21, 2015 · 53 comments

Comments

Projects
None yet
@philipstratford

philipstratford commented Aug 21, 2015

I apologise is this is already possible and documented somewhere, but I can't find it. However, what I'd really like is something basically the same as the Timeline view in the Scheduler add-on (which I'm very happy to pay for, all of your work is excellent), but with the resources as columns and the timeline going vertically down the page. So, exactly the same as the week view, really, but with days/dates in column headings replaced with resource names.

@espen

This comment has been minimized.

Show comment
Hide comment
@espen

espen Aug 24, 2015

You mean like what is described under "What’s left to be done" here: http://blog.arshaw.com/1/post/2015/08/scheduler-released.html

espen commented Aug 24, 2015

You mean like what is described under "What’s left to be done" here: http://blog.arshaw.com/1/post/2015/08/scheduler-released.html

@philipstratford

This comment has been minimized.

Show comment
Hide comment
@philipstratford

philipstratford Aug 24, 2015

Er... Yeah! :/

philipstratford commented Aug 24, 2015

Er... Yeah! :/

@arshaw

This comment has been minimized.

Show comment
Hide comment
@arshaw

arshaw Aug 26, 2015

Member

We'll leave this issue open to represent the feature request specified in Google Code's Issue 490, which has since been close because Google Code is shutting down.

Member

arshaw commented Aug 26, 2015

We'll leave this issue open to represent the feature request specified in Google Code's Issue 490, which has since been close because Google Code is shutting down.

@Efiware

This comment has been minimized.

Show comment
Hide comment
@Efiware

Efiware Sep 4, 2015

Hi
Any best guesses when this feature will be implemented? I'm looking for a calendar with this kind of view and would very much like to use (the commercial version of) FullCalendar.

Efiware commented Sep 4, 2015

Hi
Any best guesses when this feature will be implemented? I'm looking for a calendar with this kind of view and would very much like to use (the commercial version of) FullCalendar.

@AndersBachLarsen

This comment has been minimized.

Show comment
Hide comment
@AndersBachLarsen

AndersBachLarsen Sep 7, 2015

Hi
Is this feature currently being implemented? Looking forward to this very much...

AndersBachLarsen commented Sep 7, 2015

Hi
Is this feature currently being implemented? Looking forward to this very much...

@espen

This comment has been minimized.

Show comment
Hide comment
@espen

espen Sep 7, 2015

@AndersBachLarsen "This feature is a top priority for Scheduler.". So it's coming. But no ETA announced. http://blog.arshaw.com/1/post/2015/08/scheduler-released.html

espen commented Sep 7, 2015

@AndersBachLarsen "This feature is a top priority for Scheduler.". So it's coming. But no ETA announced. http://blog.arshaw.com/1/post/2015/08/scheduler-released.html

@oserra

This comment has been minimized.

Show comment
Hide comment
@oserra

oserra Sep 24, 2015

The multiresource view (multiple columns per day) is very usefull for job assigning... i.e. you've got jobs that must be done, and technical people that must do it. Sometimes a job must be done by two or more people, so it would be great you include the option to, somehow, have events linked, so that two differents events (different Ids) share a parentID (jobId?).
So, when I move an event, the linked ones move at the same time.
Or maybe the json event object may include a list of resources, and that's the way they stay alltogether aligned.

oserra commented Sep 24, 2015

The multiresource view (multiple columns per day) is very usefull for job assigning... i.e. you've got jobs that must be done, and technical people that must do it. Sometimes a job must be done by two or more people, so it would be great you include the option to, somehow, have events linked, so that two differents events (different Ids) share a parentID (jobId?).
So, when I move an event, the linked ones move at the same time.
Or maybe the json event object may include a list of resources, and that's the way they stay alltogether aligned.

@espen

This comment has been minimized.

Show comment
Hide comment
@espen

espen commented Sep 24, 2015

@oserra see #13

@mlynch6

This comment has been minimized.

Show comment
Hide comment
@mlynch6

mlynch6 Sep 28, 2015

Looking forward to this feature very much.

mlynch6 commented Sep 28, 2015

Looking forward to this feature very much.

@CodingPeak

This comment has been minimized.

Show comment
Hide comment
@CodingPeak

CodingPeak Oct 30, 2015

Any idea when this will be implemented?

CodingPeak commented Oct 30, 2015

Any idea when this will be implemented?

@mattdanna

This comment has been minimized.

Show comment
Hide comment
@mattdanna

mattdanna commented Nov 1, 2015

+1

@arshaw

This comment has been minimized.

Show comment
Hide comment
@arshaw

arshaw Nov 3, 2015

Member

I'm making some pretty good progress with this. Will post a beta on Nov 16th.

Member

arshaw commented Nov 3, 2015

I'm making some pretty good progress with this. Will post a beta on Nov 16th.

@johans

This comment has been minimized.

Show comment
Hide comment
@johans

johans Nov 3, 2015

Awsome news, keep up the good work!

johans commented Nov 3, 2015

Awsome news, keep up the good work!

@czillmann

This comment has been minimized.

Show comment
Hide comment
@czillmann

czillmann Nov 3, 2015

Great to hear :)

czillmann commented Nov 3, 2015

Great to hear :)

@CodingPeak

This comment has been minimized.

Show comment
Hide comment
@CodingPeak

CodingPeak commented Nov 3, 2015

Awesome!

@AndersBachLarsen

This comment has been minimized.

Show comment
Hide comment
@AndersBachLarsen

AndersBachLarsen commented Nov 3, 2015

Great news!

@stephen-samra

This comment has been minimized.

Show comment
Hide comment
@stephen-samra

stephen-samra Nov 3, 2015

Looking forward to this. Glad to hear it's making good progress!

stephen-samra commented Nov 3, 2015

Looking forward to this. Glad to hear it's making good progress!

@Patatou

This comment has been minimized.

Show comment
Hide comment
@Patatou

Patatou Nov 3, 2015

Awesome !

Patatou commented Nov 3, 2015

Awesome !

@Efiware

This comment has been minimized.

Show comment
Hide comment
@Efiware

Efiware Nov 3, 2015

This is indeed great news!

Efiware commented Nov 3, 2015

This is indeed great news!

@jeremymcminn

This comment has been minimized.

Show comment
Hide comment
@jeremymcminn

jeremymcminn Nov 10, 2015

Looking forward to this - haven't been able to find a stable fork with all the features the latest version of Fullcalendar has, so this will be an absolute lifesaver!

jeremymcminn commented Nov 10, 2015

Looking forward to this - haven't been able to find a stable fork with all the features the latest version of Fullcalendar has, so this will be an absolute lifesaver!

@arshaw

This comment has been minimized.

Show comment
Hide comment
@arshaw

arshaw Nov 16, 2015

Member

The beta version of this feature has been release (v1.1.0-beta).

Demo: agenda-views.html
Download: fullcalendar-scheduler-1.1.0-beta.zip

Please give it a try and report any bugs or feature requests on this ticket!

Member

arshaw commented Nov 16, 2015

The beta version of this feature has been release (v1.1.0-beta).

Demo: agenda-views.html
Download: fullcalendar-scheduler-1.1.0-beta.zip

Please give it a try and report any bugs or feature requests on this ticket!

@arshaw

This comment has been minimized.

Show comment
Hide comment
@arshaw

arshaw Nov 16, 2015

Member

This beta release is licensed solely under a Creative Commons Non-Commercial license for demo purposes only. This Vertical Resource View feature will eventually be bundled with an official release of FullCalendar Scheduler. As a reminder, Scheduler has different licensing terms than the main FullCalendar project. When v1.1.0 of Scheduler is released, the paid commercial license will retain the same pricing.

Member

arshaw commented Nov 16, 2015

This beta release is licensed solely under a Creative Commons Non-Commercial license for demo purposes only. This Vertical Resource View feature will eventually be bundled with an official release of FullCalendar Scheduler. As a reminder, Scheduler has different licensing terms than the main FullCalendar project. When v1.1.0 of Scheduler is released, the paid commercial license will retain the same pricing.

@ari

This comment has been minimized.

Show comment
Hide comment
@ari

ari Nov 16, 2015

Very interesting, thanks. I'm unfamiliar with the CC license for software (I've typically seen it for images, documentation, etc). How does this work for open source projects using your library? What is the intersection between the CC license you chose and the GPL for example?

Thanks for all your excellent work.

ari commented Nov 16, 2015

Very interesting, thanks. I'm unfamiliar with the CC license for software (I've typically seen it for images, documentation, etc). How does this work for open source projects using your library? What is the intersection between the CC license you chose and the GPL for example?

Thanks for all your excellent work.

@Efiware

This comment has been minimized.

Show comment
Hide comment
@Efiware

Efiware Nov 16, 2015

Looks very nice. Is it possible to show a full week in one column, i.e. let the time-axis span a full week?

Efiware commented Nov 16, 2015

Looks very nice. Is it possible to show a full week in one column, i.e. let the time-axis span a full week?

@Patatou

This comment has been minimized.

Show comment
Hide comment
@Patatou

Patatou Nov 16, 2015

Ty for this great work.

But, i'm a little disapointed by this version. In fact, I think (or hope :) ) that everyone want this vertical version :
------DAY #1 -----||||||---------- DAY #2 --------||||||| --------DAY #3
A-- R1 | R2 | R3-||||||-------R1 | R2 | R3-------|||||||----R1 | R2 | R3
X
I
S

Does it possible to have this view ? (Just inverse ressource and day in your version)

Ty

Patatou commented Nov 16, 2015

Ty for this great work.

But, i'm a little disapointed by this version. In fact, I think (or hope :) ) that everyone want this vertical version :
------DAY #1 -----||||||---------- DAY #2 --------||||||| --------DAY #3
A-- R1 | R2 | R3-||||||-------R1 | R2 | R3-------|||||||----R1 | R2 | R3
X
I
S

Does it possible to have this view ? (Just inverse ressource and day in your version)

Ty

@jeremymcminn

This comment has been minimized.

Show comment
Hide comment
@jeremymcminn

jeremymcminn Nov 16, 2015

Brilliant stuff - thanks for all your hard work

jeremymcminn commented Nov 16, 2015

Brilliant stuff - thanks for all your hard work

@CodingPeak

This comment has been minimized.

Show comment
Hide comment
@CodingPeak

CodingPeak Nov 16, 2015

Great work, @arshaw! When do you think this will be released as stable?

CodingPeak commented Nov 16, 2015

Great work, @arshaw! When do you think this will be released as stable?

@CodingPeak

This comment has been minimized.

Show comment
Hide comment
@CodingPeak

CodingPeak Nov 16, 2015

@Patatou, check the demo code...

This might be what you need:

    views: {
        agendaTwoDay: {
            type: 'agenda',
            duration: { days: 2 },

            // views that are more than a day will NOT do this behavior by default
            // so, we need to explicitly enable it
            groupByResource: true

            //// uncomment this line to group by day FIRST with resources underneath
            //groupByDateAndResource: true
        }
    },

Set the groupByDateAndResource to true 👍

CodingPeak commented Nov 16, 2015

@Patatou, check the demo code...

This might be what you need:

    views: {
        agendaTwoDay: {
            type: 'agenda',
            duration: { days: 2 },

            // views that are more than a day will NOT do this behavior by default
            // so, we need to explicitly enable it
            groupByResource: true

            //// uncomment this line to group by day FIRST with resources underneath
            //groupByDateAndResource: true
        }
    },

Set the groupByDateAndResource to true 👍

@Patatou

This comment has been minimized.

Show comment
Hide comment
@Patatou

Patatou Nov 16, 2015

OMG ! You're brillant ! 👍

Patatou commented Nov 16, 2015

OMG ! You're brillant ! 👍

@jeremymcminn

This comment has been minimized.

Show comment
Hide comment
@jeremymcminn

jeremymcminn Nov 16, 2015

There seems to be an issue on dayClick

dayClick: function(date, jsEvent, view, resourceObj) {
        console.log(date);
        console.log(jsEvent);
        console.log(view);
        console.log(resourceObj);
},

Both date and resourceObj parameters are coming back as undefined.

jeremymcminn commented Nov 16, 2015

There seems to be an issue on dayClick

dayClick: function(date, jsEvent, view, resourceObj) {
        console.log(date);
        console.log(jsEvent);
        console.log(view);
        console.log(resourceObj);
},

Both date and resourceObj parameters are coming back as undefined.

@philipstratford

This comment has been minimized.

Show comment
Hide comment
@philipstratford

philipstratford Nov 16, 2015

This is excellent, thanks for all your hard work, Adam!

philipstratford commented Nov 16, 2015

This is excellent, thanks for all your hard work, Adam!

@jdriesen

This comment has been minimized.

Show comment
Hide comment
@jdriesen

jdriesen Nov 16, 2015

Wow ...great stuff Adam.
Unfort. I'm having the same issue as jeremymcminn ...

jdriesen commented Nov 16, 2015

Wow ...great stuff Adam.
Unfort. I'm having the same issue as jeremymcminn ...

@jeremymcminn

This comment has been minimized.

Show comment
Hide comment
@jeremymcminn

jeremymcminn Nov 16, 2015

Also business hours causes an error.

businessHours :  {
            start: '10:00', 
            end: '15:00',
            dow: [1,2,3,4,5,6,0],
},

Uncaught TypeError: Cannot read property 'push' of undefined

jeremymcminn commented Nov 16, 2015

Also business hours causes an error.

businessHours :  {
            start: '10:00', 
            end: '15:00',
            dow: [1,2,3,4,5,6,0],
},

Uncaught TypeError: Cannot read property 'push' of undefined

@dc-dd

This comment has been minimized.

Show comment
Hide comment
@dc-dd

dc-dd Nov 17, 2015

appreciate your work

having some issues:
1.)
after instantiation:

$('#calendar').fullCalendar('addResource', { id: 'e', title: 'Room E', eventColor: 'blue' });

Seems not to rerender the header, the resource isn't shown.

2.)
also working with an empty Array for "resources" in config raises an error:

resources: []

the same is also raised when using "resources" in config as a callback function, which returns an empty Array:

resources: function( callback ) {
  setTimeout( function() {
    callback( [] );
  }, 50 );
}

3.)
some improvement:

th.fc-resource-cell { overflow: hidden; text-overflow: ellipsis; }

in addition with a title-attribute this would make header look nicer, when having a lot of resources and/or they have long titles without a breaking space

4.)
Would be nice if Background Events event objects could also accept a "resourceId" and then render only for that resource column - currently they span all resources.

dc-dd commented Nov 17, 2015

appreciate your work

having some issues:
1.)
after instantiation:

$('#calendar').fullCalendar('addResource', { id: 'e', title: 'Room E', eventColor: 'blue' });

Seems not to rerender the header, the resource isn't shown.

2.)
also working with an empty Array for "resources" in config raises an error:

resources: []

the same is also raised when using "resources" in config as a callback function, which returns an empty Array:

resources: function( callback ) {
  setTimeout( function() {
    callback( [] );
  }, 50 );
}

3.)
some improvement:

th.fc-resource-cell { overflow: hidden; text-overflow: ellipsis; }

in addition with a title-attribute this would make header look nicer, when having a lot of resources and/or they have long titles without a breaking space

4.)
Would be nice if Background Events event objects could also accept a "resourceId" and then render only for that resource column - currently they span all resources.

@jeremymcminn

This comment has been minimized.

Show comment
Hide comment
@jeremymcminn

jeremymcminn Nov 18, 2015

Agreed with dc-dd, if background-event objects could also have a resourceId that would be brilliant!

Thanks for all your hard work on this Adam

jeremymcminn commented Nov 18, 2015

Agreed with dc-dd, if background-event objects could also have a resourceId that would be brilliant!

Thanks for all your hard work on this Adam

@Patatou

This comment has been minimized.

Show comment
Hide comment
@Patatou

Patatou Nov 19, 2015

Hmmm... can't test it for the moment.

I've change nothing in my code, except .js, and directly this error appear :
Uncaught TypeError: Cannot read property 'prototype' of undefinedextend
@ scheduler.js:17(anonymous function)
@ scheduler.js:1882(anonymous function)
@ scheduler.js:1932slice
@ scheduler.js:12(anonymous function)
@ scheduler.js:14

No error with old version (1.0.2)... omw...

Patatou commented Nov 19, 2015

Hmmm... can't test it for the moment.

I've change nothing in my code, except .js, and directly this error appear :
Uncaught TypeError: Cannot read property 'prototype' of undefinedextend
@ scheduler.js:17(anonymous function)
@ scheduler.js:1882(anonymous function)
@ scheduler.js:1932slice
@ scheduler.js:12(anonymous function)
@ scheduler.js:14

No error with old version (1.0.2)... omw...

@dc-dd

This comment has been minimized.

Show comment
Hide comment
@dc-dd

dc-dd Nov 19, 2015

@Patatou : Do you use fullcalendar 2.5.0 beta? if not please try

dc-dd commented Nov 19, 2015

@Patatou : Do you use fullcalendar 2.5.0 beta? if not please try

@Patatou

This comment has been minimized.

Show comment
Hide comment
@Patatou

Patatou Nov 19, 2015

Did'nt see this release, gonna try it immediately

Patatou commented Nov 19, 2015

Did'nt see this release, gonna try it immediately

@Patatou

This comment has been minimized.

Show comment
Hide comment
@Patatou

Patatou Nov 19, 2015

<--- Dumb :)

Work fine with FC beta 2.5

Ty 😗

Patatou commented Nov 19, 2015

<--- Dumb :)

Work fine with FC beta 2.5

Ty 😗

@Patatou

This comment has been minimized.

Show comment
Hide comment
@Patatou

Patatou Nov 19, 2015

:'(
This issue : fullcalendar/fullcalendar#2892 still present... It's a big probleme (for me :) ) because can't display shceluder in vertical line with duration bigger than 3 days.

Patatou commented Nov 19, 2015

:'(
This issue : fullcalendar/fullcalendar#2892 still present... It's a big probleme (for me :) ) because can't display shceluder in vertical line with duration bigger than 3 days.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Nov 19, 2015

This is awesome. Can we have an option to do days rather than times on the left vertical axis?

Thanks,
TL

ghost commented Nov 19, 2015

This is awesome. Can we have an option to do days rather than times on the left vertical axis?

Thanks,
TL

@johans

This comment has been minimized.

Show comment
Hide comment
@johans

johans Nov 20, 2015

Just wanted to confirm the same problem as @jeremymcminn reported above with the dayClick function.

johans commented Nov 20, 2015

Just wanted to confirm the same problem as @jeremymcminn reported above with the dayClick function.

@dc-dd

This comment has been minimized.

Show comment
Hide comment
@dc-dd

dc-dd Nov 20, 2015

Is there a way to have a separate normal "agendaDay" and an "agendaDay" with resources?
Currently setting "resources" will transform the normal "agendaDay" (as also the "basicDay") into a resource view.

edit:
Nevermind, found it :)

views: {
    verticalResourceView: {
        type: 'agenda',
        duration: {days: 1},
        buttonText: 'vertical'
    },
    agendaDay: {
        resources: false
    }
},
header: {
    right: 'agendaDay verticalResourceView agendaWeek month'
},
resources: function( callback ) { // ...

dc-dd commented Nov 20, 2015

Is there a way to have a separate normal "agendaDay" and an "agendaDay" with resources?
Currently setting "resources" will transform the normal "agendaDay" (as also the "basicDay") into a resource view.

edit:
Nevermind, found it :)

views: {
    verticalResourceView: {
        type: 'agenda',
        duration: {days: 1},
        buttonText: 'vertical'
    },
    agendaDay: {
        resources: false
    }
},
header: {
    right: 'agendaDay verticalResourceView agendaWeek month'
},
resources: function( callback ) { // ...
@arshaw

This comment has been minimized.

Show comment
Hide comment
@arshaw

arshaw Nov 23, 2015

Member

Many of these issues are now resolved!
Just released v1.1.0-beta2.
Requires fullcalendar core v2.5.0-beta2.
Demo

Responses:

@ari - there is no intersection between the CC and GPL licenses. you must chose one of them, and there is no overlap in terms. more info

@jeremymcminn, @jdriesen, @johans - dayClick issue has been fixed

@jeremymcminn - businessHours issue has been fixed

@dc-dd - can you break down your issues and submit as separate tickets?

@dc-dd, @jeremymcminn - background events do accept a resourceId. should work.

@dc-dd - in response to your last comment, use groupByResource with view-specific options.

Member

arshaw commented Nov 23, 2015

Many of these issues are now resolved!
Just released v1.1.0-beta2.
Requires fullcalendar core v2.5.0-beta2.
Demo

Responses:

@ari - there is no intersection between the CC and GPL licenses. you must chose one of them, and there is no overlap in terms. more info

@jeremymcminn, @jdriesen, @johans - dayClick issue has been fixed

@jeremymcminn - businessHours issue has been fixed

@dc-dd - can you break down your issues and submit as separate tickets?

@dc-dd, @jeremymcminn - background events do accept a resourceId. should work.

@dc-dd - in response to your last comment, use groupByResource with view-specific options.

@delx

This comment has been minimized.

Show comment
Hide comment
@delx

delx Nov 23, 2015

@arshaw

I think I found a bug when calling refetchResources. Calling refetchResources does not work the first time. The new resources do not show up. Strangely it works for subsequent refetchResources calls.

I used your demo to reproduce the bug.

I changed the resources property to a function:

resources: function(callback) {
    callback([{id: 'a', title: 'TIMESTAMP=' + Date.now()}]);
},

Furthermore I added a button to test refetchResources:

<a href="#" onclick="$('#calendar').fullCalendar('refetchResources');return false">Change resources</a>

I would appreciate a quick bugfix. Thanks in advance.

delx commented Nov 23, 2015

@arshaw

I think I found a bug when calling refetchResources. Calling refetchResources does not work the first time. The new resources do not show up. Strangely it works for subsequent refetchResources calls.

I used your demo to reproduce the bug.

I changed the resources property to a function:

resources: function(callback) {
    callback([{id: 'a', title: 'TIMESTAMP=' + Date.now()}]);
},

Furthermore I added a button to test refetchResources:

<a href="#" onclick="$('#calendar').fullCalendar('refetchResources');return false">Change resources</a>

I would appreciate a quick bugfix. Thanks in advance.

@jeremymcminn

This comment has been minimized.

Show comment
Hide comment
@jeremymcminn

jeremymcminn Nov 23, 2015

@arshaw thank you for getting these fixes sorted so quick! Looking forward to implementing this new view in my app

jeremymcminn commented Nov 23, 2015

@arshaw thank you for getting these fixes sorted so quick! Looking forward to implementing this new view in my app

@dc-dd

This comment has been minimized.

Show comment
Hide comment
@dc-dd

dc-dd Nov 23, 2015

@arshaw

@dc-dd - can you break down your issues and submit as separate tickets?

Currently "those empty Array for resources" issues are not reproducible any more with beta2.

Thanks there for.

But as @delx pointed out there are now other problems.

It seems they occur with each resources change. So calling "refetchResources" twice will produce an expected result - of course calling it twice is a not expected to do.

I put up a fiddle for demonstration purposes:
http://jsfiddle.net/1nyed0p3/2/

quick explanation:

  • the button "refetchResources" will do a $('#calendar').fullCalendar('refetchResources');
  • the checkbox "refetch twice", will do a 'refetchResources' twice when pressing that button
  • the radios define the resources
    • "Empty" for empty resources
    • "A" for one resource of resourceId "a"
    • "B" for one resource of resourceId "b"
    • "A and B" for two columns of resourceId "a" and resourceId "b"

When running you will first see the result for empty resources, which is fine.

  • check "A" and press "refetchResources" - this produces an unexpected behaviour, the events shown are correct, but the column header is not updated correctly
  • press "refetchResources" again - now also the column header is rendered correctly

Any further change combinations have the same result, pressing "refetchResources" once doesn't update the header column correctly, it have to use "refetchResources" twice,
as also can be seen when checking "refetch twice", then "refetchResources" is called every time twice producing correct behaviour for events shown and rendered column headers.

dc-dd commented Nov 23, 2015

@arshaw

@dc-dd - can you break down your issues and submit as separate tickets?

Currently "those empty Array for resources" issues are not reproducible any more with beta2.

Thanks there for.

But as @delx pointed out there are now other problems.

It seems they occur with each resources change. So calling "refetchResources" twice will produce an expected result - of course calling it twice is a not expected to do.

I put up a fiddle for demonstration purposes:
http://jsfiddle.net/1nyed0p3/2/

quick explanation:

  • the button "refetchResources" will do a $('#calendar').fullCalendar('refetchResources');
  • the checkbox "refetch twice", will do a 'refetchResources' twice when pressing that button
  • the radios define the resources
    • "Empty" for empty resources
    • "A" for one resource of resourceId "a"
    • "B" for one resource of resourceId "b"
    • "A and B" for two columns of resourceId "a" and resourceId "b"

When running you will first see the result for empty resources, which is fine.

  • check "A" and press "refetchResources" - this produces an unexpected behaviour, the events shown are correct, but the column header is not updated correctly
  • press "refetchResources" again - now also the column header is rendered correctly

Any further change combinations have the same result, pressing "refetchResources" once doesn't update the header column correctly, it have to use "refetchResources" twice,
as also can be seen when checking "refetch twice", then "refetchResources" is called every time twice producing correct behaviour for events shown and rendered column headers.

@lizhou86

This comment has been minimized.

Show comment
Hide comment
@lizhou86

lizhou86 Nov 24, 2015

@arshaw
Thanks for the great work.
I just found an issue with "select" callback on week and month view (possibly because they are not in vertical resource display mode)

To reproduce In you demo:
http://fullcalendar.io/js/fullcalendar-scheduler-1.1.0-beta2/demos/agenda-views.html

Go to week or month view and try to do select and console output "Uncaught TypeError: Cannot read property 'resourceId' of undefined" and callback will not be fired.

Thanks!

lizhou86 commented Nov 24, 2015

@arshaw
Thanks for the great work.
I just found an issue with "select" callback on week and month view (possibly because they are not in vertical resource display mode)

To reproduce In you demo:
http://fullcalendar.io/js/fullcalendar-scheduler-1.1.0-beta2/demos/agenda-views.html

Go to week or month view and try to do select and console output "Uncaught TypeError: Cannot read property 'resourceId' of undefined" and callback will not be fired.

Thanks!

@arshaw

This comment has been minimized.

Show comment
Hide comment
@arshaw

arshaw Nov 25, 2015

Member

good catch @lizhou86 🎱

Member

arshaw commented Nov 25, 2015

good catch @lizhou86 🎱

@arshaw

This comment has been minimized.

Show comment
Hide comment
@arshaw

arshaw Dec 1, 2015

Member

This has been release in v1.1. Please enter any additional bugs or feature requests as separate tickets. Thanks!

http://fullcalendar.io/docs/vertical_resource_view/getting_started/
https://github.com/fullcalendar/fullcalendar-scheduler/releases/tag/v1.1.0

Member

arshaw commented Dec 1, 2015

This has been release in v1.1. Please enter any additional bugs or feature requests as separate tickets. Thanks!

http://fullcalendar.io/docs/vertical_resource_view/getting_started/
https://github.com/fullcalendar/fullcalendar-scheduler/releases/tag/v1.1.0

@Hanamant-Kadlimatti

This comment has been minimized.

Show comment
Hide comment
@Hanamant-Kadlimatti

Hanamant-Kadlimatti Jun 7, 2016

hi iam creating vertical resources in fullcalendar-scheduler its working fine but events are not coming.
help me.

Hanamant-Kadlimatti commented Jun 7, 2016

hi iam creating vertical resources in fullcalendar-scheduler its working fine but events are not coming.
help me.

@arshaw

This comment has been minimized.

Show comment
Hide comment
@arshaw

arshaw Jun 8, 2016

Member

hello @Hanamant-Kadlimatti this issue is closed. could you please proceed with following "Getting Help"
http://fullcalendar.io/support/

Member

arshaw commented Jun 8, 2016

hello @Hanamant-Kadlimatti this issue is closed. could you please proceed with following "Getting Help"
http://fullcalendar.io/support/

@Hanamant-Kadlimatti

This comment has been minimized.

Show comment
Hide comment
@Hanamant-Kadlimatti

Hanamant-Kadlimatti Jun 8, 2016

Thank U I will try it.

Hanamant-Kadlimatti commented Jun 8, 2016

Thank U I will try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment