New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix week view column title for en-gb #220

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@gidoca

gidoca commented Feb 24, 2015

Since Fullcalendar 2.3, the display of the column header in the week views is broken when the language is set to en-gb. Instead of the weekday and date, it just displays "object Object", see this js-fiddle.

@arshaw

This comment has been minimized.

Show comment
Hide comment
@arshaw

arshaw Feb 25, 2015

Member

Gaa, this is embarrassing. Thanks for the fix.

PS- I'm not actually sure if lang files can specify a views option. What you are seeing might be the date format falling back to the one being computed off of moment's settings (which might be good enough actually). I forget why I overrode en-bg specifically.

Member

arshaw commented Feb 25, 2015

Gaa, this is embarrassing. Thanks for the fix.

PS- I'm not actually sure if lang files can specify a views option. What you are seeing might be the date format falling back to the one being computed off of moment's settings (which might be good enough actually). I forget why I overrode en-bg specifically.

@gidoca

This comment has been minimized.

Show comment
Hide comment
@gidoca

gidoca Feb 26, 2015

You are right, it works perfectly fine without the option.

gidoca commented Feb 26, 2015

You are right, it works perfectly fine without the option.

@arshaw

This comment has been minimized.

Show comment
Hide comment

@arshaw arshaw closed this Mar 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment