Set 'this' context properly in FuncEventSource #3848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code sets the `this` context when invoking the user-defined event source function. However it uses `this.calendar`, which is undefined in the `Promise` callback. It should be using `_this` to access the correct context.
|
thanks |
|
released in 3.6.0 |
|
Awesome, cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code sets the
thiscontext when invoking the user-defined event source function. However it usesthis.calendar, which is undefined in thePromisecallback. It should be using_thisto access the correct calendar object.The default implementation is a fairly innocuous bug and won't cause any issues unless the caller tries to use
thisin their event source function. However, if you're inuse strictmode (i.e. you've includedfullcalendaras part of a build-chain) the browser will throw errors and stop execution.https://jsbin.com/sepeparuse/edit?html,js,console,output