New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the elements z-index as base for z-index calculations when resizing and dragging #58

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@ClemensSchneider

ClemensSchneider commented Jun 22, 2012

When resizing and dragging, a fixed z-index was used and set (in case of resizing) on the event-element. If the z-index was altered by the developer, it was reset after resizing.
With this patch, the original z-index of the event-element is taken into account.

@arshaw

This comment has been minimized.

Show comment
Hide comment
@arshaw

arshaw Aug 3, 2013

Member

I made an alternate solution in 664ec8f, and committed to the upcoming release branch.

In your patch, to handle customized z-indexes, you are setting the dragged z-index to be the original +1. But what we really want to do is to make it appear above all other events, so we need to set the z-index to higher than all the other events' z-indexes, which could be custom as well.

That solution could get hairy, so my solution was to take the inline z-index styles on the event elements, and put them into the stylesheet, so they could be more easily overridden.

Member

arshaw commented Aug 3, 2013

I made an alternate solution in 664ec8f, and committed to the upcoming release branch.

In your patch, to handle customized z-indexes, you are setting the dragged z-index to be the original +1. But what we really want to do is to make it appear above all other events, so we need to set the z-index to higher than all the other events' z-indexes, which could be custom as well.

That solution could get hairy, so my solution was to take the inline z-index styles on the event elements, and put them into the stylesheet, so they could be more easily overridden.

@arshaw arshaw closed this Aug 3, 2013

@arshaw

This comment has been minimized.

Show comment
Hide comment
@arshaw

arshaw Aug 11, 2013

Member

just released in v1.6.3

Member

arshaw commented Aug 11, 2013

just released in v1.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment