New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add company industry support #59

Merged
merged 4 commits into from Oct 24, 2017

Conversation

Projects
None yet
2 participants
@MattSainz
Contributor

MattSainz commented Oct 23, 2017

Adds support for company industry data and bumps version to 5.5.0

@fullcontact/data-integrations

@ParisMi

This comment has been minimized.

Show comment
Hide comment
@ParisMi

ParisMi Oct 24, 2017

Contributor

looking good -- can you update ResponseModelTest.companyDeserializationTest() and make sure that things don't blow up if you try to deserialize a company doc where there is no industries key?

Contributor

ParisMi commented Oct 24, 2017

looking good -- can you update ResponseModelTest.companyDeserializationTest() and make sure that things don't blow up if you try to deserialize a company doc where there is no industries key?

@@ -9,6 +9,7 @@
"logo" : "https://d2ojpxxtu63wzl.cloudfront.net/static/1bacd7306731a30d2a9f024eeb1dcff1_94d77dcdedbfe40707ac4a75ca4f4d2978bffc20b2e33a3288ea9e4d47f5af6c",
"website" : "https://www.fullcontact.com",
"languageLocale" : "en",
"industries":[],

This comment has been minimized.

@ParisMi

ParisMi Oct 24, 2017

Contributor

it works OK even if there's no key at all, right? Otherwise this LGTM

@ParisMi

ParisMi Oct 24, 2017

Contributor

it works OK even if there's no key at all, right? Otherwise this LGTM

This comment has been minimized.

@MattSainz

MattSainz Oct 24, 2017

Contributor

Yes since the pr builder passed when I first merged and I just tested again locally.

@MattSainz

MattSainz Oct 24, 2017

Contributor

Yes since the pr builder passed when I first merged and I just tested again locally.

@MattSainz MattSainz merged commit ad057f6 into master Oct 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@MattSainz MattSainz deleted the ind-update branch Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment