Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load image using glide into ImageViews #20

Merged
merged 1 commit into from Mar 12, 2020
Merged

load image using glide into ImageViews #20

merged 1 commit into from Mar 12, 2020

Conversation

@sabrina-li
Copy link
Contributor

sabrina-li commented Mar 11, 2020

Using Glide to load images into ImageView.
benchmark between glide, Picasso and Coil: https://proandroiddev.com/coil-vs-picasso-vs-glide-get-ready-go-774add8cfd40
for now Glide seems to be superior
Glide also cache ImageView size pictures, arguably what I want for RecyclerView, having to re-bind the images if user scrolls more than a couple view holders

@patrick-fs

This comment has been minimized.

Copy link
Member

patrick-fs commented Mar 12, 2020

Glide also cache ImageView size pictures, arguably what I want for RecyclerView, having to re-bind the images if user scrolls more than a couple view holders

Great point!

Copy link
Member

patrick-fs left a comment

LGTM

@sabrina-li sabrina-li merged commit eb62aaf into master Mar 12, 2020
@sabrina-li sabrina-li deleted the sabrina/loadImages branch Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.