Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sabrina/customer info repo #29

Merged
merged 10 commits into from Mar 24, 2020
Merged

Sabrina/customer info repo #29

merged 10 commits into from Mar 24, 2020

Conversation

@sabrina-li
Copy link
Contributor

sabrina-li commented Mar 23, 2020

  • fix a typo in customerInfo.java
  • add CustomerInfoRepository.java which hold a instance of CustomerInfo serving as single source of truth, no need for using live data for the customer info object since it is only needed for when the ui is created/destroyed and when user hit purchase
  • Using lighter weight shared pref to persist data instead of having to use database ops which are heavier
  • hold a live data for "isLoading" to make show/hide the loading icon when data is being loaded/updated from shared pref
@sabrina-li sabrina-li force-pushed the sabrina/customerInfoRepo branch 3 times, most recently from 605acd9 to e69c2d8 Mar 23, 2020
Copy link
Member

patrick-fs left a comment

LGTM except for some variable and method names that need to be fixedup. Please see my comments in the thread.

@sabrina-li sabrina-li merged commit 4be3343 into master Mar 24, 2020
@sabrina-li sabrina-li deleted the sabrina/customerInfoRepo branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.