Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor product service to support mock apis #11

Merged
merged 1 commit into from Mar 20, 2020
Merged

Conversation

@van-fs
Copy link
Member

van-fs commented Mar 19, 2020

This PR updates the ProductService to better support the mock API out of the box:

  • Updated the environment config to default to localApi
  • Updated the ProductService to better use the localApi for products and products/:id routes
  • Added a visual popup using a snackbar if the user improperly configures the remoteApi
Copy link
Member

patrick-fs left a comment

LGTM

@van-fs van-fs merged commit 85a2b4b into master Mar 20, 2020
@van-fs van-fs deleted the van/product-service-local branch Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.