Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v1 #14

Merged
merged 8 commits into from Mar 23, 2020
Merged

release v1 #14

merged 8 commits into from Mar 23, 2020

Conversation

@van-fs
Copy link
Member

van-fs commented Mar 23, 2020

This PR readies the app for V1:

  • Updated the readme with more detailed setup/use instructions
  • Fixed a bug in the ProductService: it was picking the first value from the observable, which was an array, not the first value/product in the array
  • Updated titles to Angular Shoppe similar to Reactshoppe
  • Updated the CartComponent's title to include Your Cart; this also required a bit of shuffling on the Keep Shoppeing button
  • Updated the CheckoutComponent to have IDs on elements and exclusion rules for better compatibility with FSTA
  • Set the mock API to default out of the box
  • Bump the version to 1.0.0
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Member

patrick-fs left a comment

LGTM! I left a few comments for you to review about the Readme.

@van-fs van-fs merged commit cd7630c into master Mar 23, 2020
@van-fs van-fs deleted the van/v1 branch Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.