Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CartService #8

Merged
merged 7 commits into from Mar 16, 2020
Merged

Add CartService #8

merged 7 commits into from Mar 16, 2020

Conversation

@van-fs
Copy link
Member

van-fs commented Mar 16, 2020

This PR adds a CartService to handle shopping cart operations:

  • CartService handles all cart implementation details
  • The cart requires an API to get a product by ID, so the useMockApi flag is now false
  • Add to Cart button now communicates with the service
  • The button that displays the cart now has a badge that shows number of items in the cart
Copy link
Member

patrick-fs left a comment

LGTM

van-fs added 2 commits Mar 16, 2020
array.splice is inplace; compare index against -1
@van-fs van-fs merged commit c261578 into master Mar 16, 2020
@van-fs van-fs deleted the van/cart branch Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.