Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added CORS as middleware #4

Merged
merged 1 commit into from Mar 12, 2020
Merged

added CORS as middleware #4

merged 1 commit into from Mar 12, 2020

Conversation

@van-fs
Copy link
Member

van-fs commented Mar 12, 2020

This PR add CORS support to the Express server. This is needed because if doing local testing, your Angular/React app is running on 4200/3001 and the Express server is running on 3000. So a browser's service call between the two will fail.

This allows local testing since ports are used.
Copy link
Member

patrick-fs left a comment

LGTM

@van-fs van-fs merged commit 783614a into master Mar 12, 2020
@van-fs van-fs deleted the van/cors branch Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.