Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding hold and deploy steps to CI workflow #21

Merged
merged 5 commits into from Nov 6, 2019

Conversation

@patrick-fs
Copy link
Member

patrick-fs commented Nov 5, 2019

This is a simple three job workflow:

Build & Test --> Hold --> Deploy to NPM

Here's a sample pipeline on a test project: https://circleci.com/workflow-run/5bf54a02-19eb-4d7e-b58e-c3510969586b

@@ -19,7 +19,7 @@ import App from './App';
import FullStory from 'TBD/package-to-be-deployed';
FullStory.init('<your org id here>');
FullStory.init({ orgId: '<your org id here>' });

This comment has been minimized.

Copy link
@patrick-fs

patrick-fs Nov 5, 2019

Author Member

This is just a quick README fixup I'm sneaking in with the PR. It's not germane to the CI updates.

Copy link

sgmitchell left a comment

SGTM

requires:
- hold
<<: *masterBranchOnly

This comment has been minimized.

Copy link
@sgmitchell

sgmitchell Nov 5, 2019

nit: requiring hold which only runs on master should make this redundant

This comment has been minimized.

Copy link
@patrick-fs

patrick-fs Nov 6, 2019

Author Member

good call. Fixed

@patrick-fs patrick-fs merged commit 75290b8 into master Nov 6, 2019
1 check passed
1 check passed
ci/circleci: build-browser-sdk Your tests passed on CircleCI!
Details
@patrick-fs patrick-fs deleted the patrick/circleci-workflow-update branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.