Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds iframe options to SDK #54

Merged
merged 7 commits into from Mar 25, 2020
Merged

Adds iframe options to SDK #54

merged 7 commits into from Mar 25, 2020

Conversation

@van-fs
Copy link
Member

van-fs commented Mar 25, 2020

This PR fixes #1 and adds control over the snippet's iFrame recording options as seen in Can FullStory capture content that is presented in iframes.

README.md Outdated Show resolved Hide resolved
@patrick-fs

This comment has been minimized.

Copy link
Member

patrick-fs commented Mar 25, 2020

This is much nicer! Check out the comment I left. Also: please commit a changelog entry and a minor version bump. Make sure to bump the version in package.json and package-lock.json

@van-fs

This comment has been minimized.

Copy link
Member Author

van-fs commented Mar 25, 2020

OK, I think we're completed. I bumped to a new minor release since we've added new options.

Copy link
Member

patrick-fs left a comment

LGTM!

@van-fs van-fs merged commit e804d3d into master Mar 25, 2020
1 check passed
1 check passed
ci/circleci: build-browser-sdk Your tests passed on CircleCI!
Details
@van-fs van-fs deleted the van/iframe-opts-bools branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.