Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating readme to show init config options as a list #55

Merged
merged 6 commits into from Mar 26, 2020

Conversation

@patrick-fs
Copy link
Member

patrick-fs commented Mar 25, 2020

This formats the Readme so that config options are more readable on NPM.

@van-fs

This comment has been minimized.

Copy link
Member

van-fs commented Mar 25, 2020

@patrick-fs Thoughts on using a list rather than headers. I'm thinking we could model this after request. I feel like that will consolidate the whitespace and matches our situation - we have one required and all other optional. So we could borrow that language as well.

@patrick-fs patrick-fs force-pushed the patrick/init_docs_format_update branch from dcf3f1b to 5b90ab0 Mar 26, 2020
@patrick-fs

This comment has been minimized.

Copy link
Member Author

patrick-fs commented Mar 26, 2020

@patrick-fs Thoughts on using a list rather than headers. I'm thinking we could model this after request. I feel like that will consolidate the whitespace and matches our situation - we have one required and all other optional. So we could borrow that language as well.

Done. Please give it a look.

@van-fs
van-fs approved these changes Mar 26, 2020
Copy link
Member

van-fs left a comment

Yasss! LGTM.

@patrick-fs patrick-fs merged commit 0328b6c into master Mar 26, 2020
1 check passed
1 check passed
ci/circleci: build-browser-sdk Your tests passed on CircleCI!
Details
@patrick-fs patrick-fs deleted the patrick/init_docs_format_update branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.