Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint on docker pitfalls #258

Merged
merged 3 commits into from Oct 6, 2021
Merged

Add hint on docker pitfalls #258

merged 3 commits into from Oct 6, 2021

Conversation

bjrne
Copy link
Contributor

@bjrne bjrne commented Oct 5, 2021

There are some pitfalls when using docker.
Technically, these are docker options and not a grpcurl options, but since docker is featured as an easy installation variant, I think it belongs here.
If there were a wiki of some kind, I would go more in depth and also include some common error messages (to make googling easier), but since this is at the relative top of the readme, I kept it very brief.

@bjrne bjrne changed the title Add hint on docker pitfall Add hint on docker pitfalls Oct 6, 2021
Copy link
Contributor

@jhump jhump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I made several suggestions to the copy to hopefully improve clarity.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Joshua Humphries <jh@fullstory.com>
@jhump jhump merged commit 30b8cd1 into fullstorydev:master Oct 6, 2021
@bjrne bjrne deleted the patch-1 branch October 6, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants