Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harolddavis/ch106773/create an api service #5

Merged
merged 12 commits into from Mar 10, 2020

Conversation

@HaroldFS
Copy link
Contributor

HaroldFS commented Mar 4, 2020

Create an API Service

  • Create the singleton
  • Add main endpoint as a property
  • Setup header for method to get shop items
  • Allows Local Networking
  • JSONSerialization
HaroldFS added 2 commits Mar 4, 2020
- Create the singleton
- Add main endpoint as a property
- Setup header for method to get shop items
@sabrina-li

This comment has been minimized.

Copy link

sabrina-li commented Mar 4, 2020

On a side note, maybe we can rename the root folder to something like 'swift' so we have
ios-shoppe-demo > swift > ios-shoppe-demo
rather than having:
Screen Shot 2020-03-04 at 2 22 51 PM

HaroldFS added 5 commits Mar 6, 2020
- fixed error guard statment
- Improved Try by adding a `catch` for errors
Made baseURL a computed property that retrives the URL from the config file.
# Conflicts:
#	swift/ios-shoppe-demo/ios-shoppe-demo.xcodeproj/project.pbxproj
#	swift/ios-shoppe-demo/ios-shoppe-demo/ShoppeItem.swift
HaroldFS added 3 commits Mar 9, 2020
# Conflicts:
#	swift/ios-shoppe-demo/ios-shoppe-demo.xcodeproj/project.pbxproj
#	swift/ios-shoppe-demo/ios-shoppe-demo/ShoppeItem.swift
…i-service

# Conflicts:
#	swift/ios-shoppe-demo/ios-shoppe-demo.xcodeproj/project.pbxproj
@patrick-fs

This comment has been minimized.

Copy link
Member

patrick-fs commented Mar 10, 2020

On a side note, maybe we can rename the root folder to something like 'swift' so we have
ios-shoppe-demo > swift > ios-shoppe-demo
rather than having:
Screen Shot 2020-03-04 at 2 22 51 PM

It looks like this could use another flattening-out. For better clarity, these files can live at
ios-shoppe-demo > swift

image
The .gitignore file can live at this level as well.

Basically, remove the middle ios-shoppe-demo that's currently in the path.

Rather than

ios-shoppe-demo/swift/ios-shoppe-demo/ios-shoppe-demo

do

ios-shoppe-demo/swift/ios-shoppe-demo

You're close! Just another directory shift. git mv might be able to help you. Please let me know if you have any questions.

renamed file from shopeeItem to product
@HaroldFS HaroldFS requested a review from patrick-fs Mar 10, 2020
Copy link
Member

patrick-fs left a comment

LGTM! Thanks for working through this PR with me. I left a comment for you to review.

@HaroldFS HaroldFS merged commit 1719dea into master Mar 10, 2020
@HaroldFS HaroldFS deleted the harolddavis/ch106773/create-an-api-service branch Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.