Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harolddavis/ch106781/create a shoppeitem class #7

Merged
merged 3 commits into from Mar 6, 2020

Conversation

@HaroldFS
Copy link
Contributor

HaroldFS commented Mar 4, 2020

Create a ShoppeItem class

Properties

  • title
  • description
  • price
  • imageName
  • image
HaroldFS added 2 commits Mar 4, 2020
Properties
- title
- description
- price
- imageName
- image
class ShoppeItem {
var title: String
var description: String
var price: String

This comment has been minimized.

Copy link
@patrick-fs

This comment has been minimized.

Copy link
@HaroldFS

HaroldFS Mar 6, 2020

Author Contributor

What is the Unit used for?

Copy link
Member

patrick-fs left a comment

LGTM - please go ahead and update your ShoppeItem type to reflect changes to the "Product" type before merging.

Also: checkout @sabrina-li's comment on the other branch #5

I used "product" in stead of "shopItem" in my code, should we use the same names? If so, what's a good generic name for this?

Added a Unit property
@HaroldFS HaroldFS merged commit be2db79 into master Mar 6, 2020
@HaroldFS HaroldFS deleted the harolddavis/ch106781/create-a-shoppeitem-class branch Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.