Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patrick/adding cart button #10

Merged
merged 9 commits into from Mar 25, 2020
Merged

Patrick/adding cart button #10

merged 9 commits into from Mar 25, 2020

Conversation

@patrick-fs
Copy link
Member

patrick-fs commented Mar 20, 2020

I've added a "My Cart" button that displays the size of the current cart. I'm using the Redux useSelector hook to update state.

@van-fs I'm going to ask Tim to review this one to ensure the Redux-y things look good and then assign to you once it LGTT.

src/components/CartButton.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

timjchin left a comment

This LGTM! My apologies for the delay.

@van-fs
van-fs approved these changes Mar 25, 2020
Copy link
Member

van-fs left a comment

LGTM

@patrick-fs patrick-fs merged commit b1dbdaf into master Mar 25, 2020
@patrick-fs patrick-fs deleted the patrick/adding_cart_button branch Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.