Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify swift-syntax version in manifest #41

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Specify swift-syntax version in manifest #41

merged 2 commits into from
Dec 3, 2023

Conversation

infinitepower18
Copy link
Contributor

Specified a swift-syntax version in the Package.swift manifest to resolve an error when trying to add csv2img to a project.

@fummicc1
Copy link
Owner

fummicc1 commented Dec 1, 2023

Thank you!
it seems that error happens in CsvBuilder because of this version updtae.
Could you also fix the error? If it's difficult, I can undertake it.🙆‍♂️

@infinitepower18
Copy link
Contributor Author

Hi, I'm not sure why that is. I haven't come across this when using the package.

The problem was, without a version defined, the package cannot be added to an Xcode project and will display this error:

Untitled

@fummicc1
Copy link
Owner

fummicc1 commented Dec 3, 2023

I see. I think you don't use CsvBuilder library, but just use Csv2Img library. so let me add a new commit to address above issue 🙏

@fummicc1
Copy link
Owner

fummicc1 commented Dec 3, 2023

The problem was, without a version defined, the package cannot be added to an Xcode project and will display this error:

I agree! Thank you for your PR :)

I will merge this update as CI passes.

@fummicc1 fummicc1 merged commit cf1113b into fummicc1:main Dec 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants