Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to run Rubocop in parallel mode #16

Closed
texpert opened this issue Jul 19, 2017 · 4 comments
Closed

Add possibility to run Rubocop in parallel mode #16

texpert opened this issue Jul 19, 2017 · 4 comments

Comments

@texpert
Copy link
Contributor

texpert commented Jul 19, 2017

As of version 0.49, Rubocop could be run parallelized:

rubocop --parallel

Could you, please, implement this option?

@vassilevsky
Copy link
Contributor

Good idea. Thanks, Aurel.

My main concern is the resulting report. Will it still be a single JSON file if RuboCop runs in parallel? Face Control parses the JSON report, so this is important.

Another option might be to add an option to Face Control to not run RuboCop at all, and just read the JSON report. In this case Face Control users will be able to run RuboCop however they like.

We don't actively use Face Control at the moment so we will not be doing this ourselves. However, we'll accept a nice pull request for either of these solutions.

@texpert
Copy link
Contributor Author

texpert commented Oct 25, 2020

It will be a single JSON file, Ilya!

"Files are inspected in parallel, but cops are being run in sequence on a given file." - see rubocop/rubocop#4272

So, I have created a PR for enabling parallel mode - #21

@vassilevsky
Copy link
Contributor

That's nice. Thanks.

@vassilevsky
Copy link
Contributor

I thought this was enough of a reason to finally publish v1.0.0 so I did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants