New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation on template name #2

Closed
amitguptagwl opened this Issue May 21, 2018 · 8 comments

Comments

Projects
None yet
3 participants
@amitguptagwl
Member

amitguptagwl commented May 21, 2018

Match it application allows to save your design as template so it can be applied on other designs. It saves your effort to arrange symbols on a card.

As a part of this issue, if user deleted the name of template from the text box and try to save the template, it should highlight the text box with red color outline instead of giving error in console.

@sblasa

This comment has been minimized.

sblasa commented May 24, 2018

Hi @amitguptagwl, do you need help with this issue?
Thanks!

@amitguptagwl

This comment has been minimized.

Member

amitguptagwl commented May 25, 2018

Thanks @sblasa . Every contribution matters. Please read CONTRIBUTING.md for technical guidance for any change.

@amitguptagwl

This comment has been minimized.

Member

amitguptagwl commented May 28, 2018

To make it simple I've update CONTRIBUTING.md . Now you need not to generate any file. Just do the changes and they should be reflected.

@sblasa

This comment has been minimized.

sblasa commented May 28, 2018

@amitguptagwl Okay, no problem. I will review the CONTRIBUTING.md again. Thanks!

@amitguptagwl

This comment has been minimized.

Member

amitguptagwl commented Jun 3, 2018

@sblasa have you get the chance to look into?

@omkar1212

This comment has been minimized.

Contributor

omkar1212 commented Oct 2, 2018

pushed in a fix for this issue

@sblasa

This comment has been minimized.

sblasa commented Oct 3, 2018

@amitguptagwl , I'm sorry, I forgot this issue and missed your email. 😧 Just catching up again. Thanks to @omkar1212 for taking this one. 👍

@amitguptagwl

This comment has been minimized.

Member

amitguptagwl commented Oct 4, 2018

no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment