Handle infinite channels in channel fapply #139

Merged
merged 1 commit into from Jan 6, 2016

Conversation

Projects
None yet
2 participants
@yanatan16
Contributor

yanatan16 commented Jan 6, 2016

Handle infinite channels in fapply by using core.async/map. It has the same semantics as the previous implementation for finite channels. The differences:

  • Only one of the input channels must close to close the output channel (reducing memory usage for one long-unclosed channel)
  • Handles either one or both infinite channels
  • Output values available as soon as both input channels have input values available (instead of waiting for both to close).

This aligns with the other changes in #136 which handle infinite channels in mappend.

@niwinz

This comment has been minimized.

Show comment
Hide comment
@niwinz

niwinz Jan 6, 2016

Member

Nice! Thanks!

Member

niwinz commented Jan 6, 2016

Nice! Thanks!

niwinz added a commit that referenced this pull request Jan 6, 2016

Merge pull request #139 from yanatan16/patch-chan-apply
Handle infinite channels in channel fapply

@niwinz niwinz merged commit 69ba481 into funcool:master Jan 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@niwinz

This comment has been minimized.

Show comment
Hide comment
@niwinz

niwinz Jan 6, 2016

Member

1.3.0-SNAPSHOT is released with your change.

Member

niwinz commented Jan 6, 2016

1.3.0-SNAPSHOT is released with your change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment