Skip to content
Permalink
Browse files
Stop bundling xregexp
This change makes cuerdas compatible with the latest ClojureScript release: npm
dependencies does not need to be bundled and they can be declared by adding a
key in deps.cljs - the compiler will see the dep is declared and will
try to install in dependent libraries.
  • Loading branch information
arichiardi authored and niwinz committed Aug 20, 2018
1 parent 3f6eca1 commit a8443724e22435e052af4149b27dd2169f3216ac
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 2,705 deletions.
@@ -1,5 +1,2 @@
{:externs ["externs.js"]
:foreign-libs
[{:file "xregexp/xregexp.js"
Copy link
@benzap

benzap Feb 20, 2019

Removing the foreign lib of xregexp prevents me from using cuerdas from clojurescript, I get errors surrounding the non-existence of xregexp in versions after this change. Running lein deps also does not pull in the appropriate dependency. Is there something i'm missing?

Cheers

Copy link
@niwinz

niwinz Feb 20, 2019

Member

Seems like there are some problems with :npm-deps I don't know why. Please use the previous version until i fix it properly.

Copy link
@benzap

benzap Feb 20, 2019

@niwinz you might need to include :install-deps true as an additional configuration option, but more recent updates claim that this is true by default so i'm not sure. Worth a shot!

I'll downgrade till this is worked out, this library is still top-notch.

Cheers

Copy link
@gfredericks

gfredericks Mar 25, 2019

I'm also having this problem.

Copy link
@niwinz

niwinz Mar 30, 2019

Member

After testing a little bit, the npm deps is working correctly, just you need to include :install-deps true in the build configuration. But... in any case I go to revert this change, because using npm dep on advanced compilation emits a lot of warnings, because xregexp is not very friendly with closure compiler, so the best way to include it, is just the old way.

:file-min "xregexp/xregexp.min.js"
:provides ["cuerdas.vendor.xregexp"]}]}
:npm-deps {:xregexp "4.2.0"}}

0 comments on commit a844372

Please sign in to comment.