Thought the koans could use a little positive feedback #5

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@wcbarksdale
Contributor

wcbarksdale commented Mar 16, 2012

No description provided.

@trptcolin

This comment has been minimized.

Show comment Hide comment
@trptcolin

trptcolin Mar 17, 2012

Owner

I like the idea here, especially considering cases where one accidentally writes an infinite loop or something, so you see exactly where the problem is.

It does seem like this will make the output pretty noisy for koan projects with lots of files, once you get near the end. I'm interested to hear whether others think that's a problem or not. I think it's probably fine, since the actual error will always be at the bottom of the output.

Any opinions on this, @abedra & @sritchie?

Owner

trptcolin commented Mar 17, 2012

I like the idea here, especially considering cases where one accidentally writes an infinite loop or something, so you see exactly where the problem is.

It does seem like this will make the output pretty noisy for koan projects with lots of files, once you get near the end. I'm interested to hear whether others think that's a problem or not. I think it's probably fine, since the actual error will always be at the bottom of the output.

Any opinions on this, @abedra & @sritchie?

@trptcolin

This comment has been minimized.

Show comment Hide comment
@trptcolin

trptcolin Feb 26, 2013

Owner

Ack, really sorry I lost track of this @wcbarksdale (feel free to poke me next time!). I cherry-picked this in as 7f2c62b with two very small changes: getting rid of a space and taking out the word "ok", which I think can be inferred.

Thanks a bunch!

Owner

trptcolin commented Feb 26, 2013

Ack, really sorry I lost track of this @wcbarksdale (feel free to poke me next time!). I cherry-picked this in as 7f2c62b with two very small changes: getting rid of a space and taking out the word "ok", which I think can be inferred.

Thanks a bunch!

@trptcolin trptcolin closed this Feb 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment