Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Thought the koans could use a little positive feedback #5

Closed
wants to merge 1 commit into from

2 participants

@wcbarksdale

No description provided.

@trptcolin
Owner

I like the idea here, especially considering cases where one accidentally writes an infinite loop or something, so you see exactly where the problem is.

It does seem like this will make the output pretty noisy for koan projects with lots of files, once you get near the end. I'm interested to hear whether others think that's a problem or not. I think it's probably fine, since the actual error will always be at the bottom of the output.

Any opinions on this, @abedra & @sritchie?

@trptcolin
Owner

Ack, really sorry I lost track of this @wcbarksdale (feel free to poke me next time!). I cherry-picked this in as 7f2c62b with two very small changes: getting rid of a space and taking out the word "ok", which I think can be inferred.

Thanks a bunch!

@trptcolin trptcolin closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 16, 2012
  1. @wcbarksdale
This page is out of date. Refresh to see the latest.
Showing with 5 additions and 1 deletion.
  1. +5 −1 src/koan_engine/koans.clj
View
6 src/koan_engine/koans.clj
@@ -23,8 +23,12 @@
(defn tests-pass? [dojo-path file-path]
(u/with-dojo [dojo-path]
+ (print "Considering" file-path "...")
+ (flush)
(try (load-file file-path)
- true
+ (do
+ (println "ok")
+ true)
(catch Exception e
(println)
(println "Problem in" file-path)
Something went wrong with that request. Please try again.