New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/queue get #1308

Merged
merged 6 commits into from Nov 6, 2018

Conversation

Projects
None yet
2 participants
@pchlupacek
Contributor

pchlupacek commented Nov 6, 2018

Fixes #1293.

Needs to be squashed before merge.

pchlupacek added some commits Nov 5, 2018

@pchlupacek pchlupacek requested review from mpilquist and SystemFw Nov 6, 2018

@pchlupacek

This comment has been minimized.

Contributor

pchlupacek commented Nov 6, 2018

huh travis complains about bincompat? All I have touched is private, so this seems odd :-(

@mpilquist

This comment has been minimized.

Member

mpilquist commented Nov 6, 2018

We can add an exclusion for the Travis error.

Does this test pass too?

      Queue
         .unbounded[IO, Int]
         .flatMap { q =>
           q.dequeue.timeout(1.second) *>
             q.enqueue1(1) *>
             q.enqueue1(2) *>
             q.dequeue1
         }
         .unsafeRunSync shouldBe 1
@pchlupacek

This comment has been minimized.

Contributor

pchlupacek commented Nov 6, 2018

@mpilquist tests passes. As regard the exclusions, where to add them ?

@mpilquist

This comment has been minimized.

@pchlupacek

This comment has been minimized.

Contributor

pchlupacek commented Nov 6, 2018

Also going forward perhaps fro next release of fs2, I would like to explore, if we could implement Stream.bracket with similar signatures, essentially making canceling a stream instead of interrupting it. I think it could be possible and have bracket propagate the Case to finalizer, similarly like Bracket does in cats.

pchlupacek added some commits Nov 6, 2018

@mpilquist mpilquist merged commit b847c35 into series/1.0 Nov 6, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment