From 465cf2394e51206af0489f5154ebcb7fbd739c26 Mon Sep 17 00:00:00 2001
From: Almog Adziashvili <almoga@wix.com>
Date: Sun, 10 Mar 2024 13:47:02 +0200
Subject: [PATCH 1/2] fixed #7 #8 and upgrade storybook

---
 CHANGELOG.md                                  |  5 ++++
 package.json                                  | 28 +++++++++++--------
 .../fui-checkbox/fui-checkbox.stories.tsx     | 16 +++++------
 src/components/fui-checkbox/fui-checkbox.tsx  |  8 +++---
 src/components/fui-radio/fui-radio.tsx        |  9 ++++--
 src/components/fui-stepper/fui-stepper.tsx    |  7 +++--
 .../fui-text-input/fui-text-input.tsx         |  7 ++++-
 src/components/fui-toggle/fui-toggle.tsx      |  2 +-
 ...x => fui-icon-indeterminate-line-2x10.tsx} |  4 +--
 src/icons/icons.stories.tsx                   |  4 +--
 10 files changed, 55 insertions(+), 35 deletions(-)
 rename src/icons/{fui-icon-intermediate-line-2x10.tsx => fui-icon-indeterminate-line-2x10.tsx} (56%)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 833494c..8c934ae 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.0.0] - 2024-03-10
+* [FuiCheckbox] - Fixed naming ([#8](https://github.com/functional-ui/functional-ui-kit/issues/8))
+* [FuiTextInput / FuiRadio / FuiStepper] - Improved adherence to WCAG ([#7](https://github.com/functional-ui/functional-ui-kit/issues/7))
+* [Docs] - Upgrade to Storybook@7.6.17
+
 ## [0.1.0] - 2024-02-07
 * [FuiPopover] - Removed `react-tiny-popover` and replace with `floating-ui`
 * [FuiOptionGroup] - New Component 🎉
diff --git a/package.json b/package.json
index 7385707..3f2ef56 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "functional-ui-kit",
-  "version": "0.1.0",
+  "version": "1.0.0",
   "description": "Functional UI Kit",
   "scripts": {
     "build": "vite build --config vite.config.ts",
@@ -33,6 +33,10 @@
     "style"
   ],
   "author": "Alex Yakir",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/functional-ui/functional-ui-kit.git"
+  },
   "license": "ISC",
   "dependencies": {
     "@floating-ui/react": "^0.25.2",
@@ -44,17 +48,17 @@
     "@babel/preset-react": "^7.18.6",
     "@babel/preset-typescript": "^7.21.5",
     "@storybook/addon-designs": "^7.0.7",
-    "@storybook/addon-essentials": "^7.6.10",
-    "@storybook/addon-interactions": "^7.6.10",
-    "@storybook/addon-links": "^7.6.10",
-    "@storybook/addon-mdx-gfm": "^7.6.10",
-    "@storybook/addon-toolbars": "^7.6.10",
-    "@storybook/blocks": "^7.6.10",
-    "@storybook/manager-api": "^7.6.10",
-    "@storybook/react": "^7.6.10",
-    "@storybook/react-webpack5": "^7.6.10",
+    "@storybook/addon-essentials": "^7.6.17",
+    "@storybook/addon-interactions": "^7.6.17",
+    "@storybook/addon-links": "^7.6.17",
+    "@storybook/addon-mdx-gfm": "^7.6.17",
+    "@storybook/addon-toolbars": "^7.6.17",
+    "@storybook/blocks": "^7.6.17",
+    "@storybook/manager-api": "^7.6.17",
+    "@storybook/react": "^7.6.17",
+    "@storybook/react-webpack5": "^7.6.17",
     "@storybook/testing-library": "^0.2.2",
-    "@storybook/theming": "^7.6.10",
+    "@storybook/theming": "^7.6.17",
     "@types/react": "^18.0.0",
     "@types/react-modal": "^3.16.0",
     "@typescript-eslint/eslint-plugin": "^5.59.5",
@@ -71,7 +75,7 @@
     "prop-types": "^15.8.1",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
-    "storybook": "^7.6.10",
+    "storybook": "^7.6.17",
     "storybook-dark-mode": "^3.0.3",
     "typescript": "^5.0.4",
     "vite": "^4.4.4",
diff --git a/src/components/fui-checkbox/fui-checkbox.stories.tsx b/src/components/fui-checkbox/fui-checkbox.stories.tsx
index bad536a..4c1b581 100644
--- a/src/components/fui-checkbox/fui-checkbox.stories.tsx
+++ b/src/components/fui-checkbox/fui-checkbox.stories.tsx
@@ -20,7 +20,7 @@ const meta = {
   },
   argTypes: {
     checked: { name: '🔗 checked' },
-    intermediate: { name: '🔗 intermediate' },
+    indeterminate: { name: '🔗 indeterminate' },
     disabled: { name: '🔗 disabled' },
     checkLabel: { name: '🔗 checkLabel' },
     className: {
@@ -63,10 +63,10 @@ export const Disabled: Story = {
       <div style={{ display: 'flex', gap: 'var(--fui-space-md)' }}>
         <FuiCheckbox {...args} disabled />
         <FuiCheckbox {...args} checked disabled />
-        <FuiCheckbox {...args} intermediate disabled />
+        <FuiCheckbox {...args} indeterminate disabled />
         <FuiCheckbox {...args} checkLabel='Label' disabled />
         <FuiCheckbox {...args} checkLabel='Label' checked disabled />
-        <FuiCheckbox {...args} checkLabel='Label' intermediate disabled />
+        <FuiCheckbox {...args} checkLabel='Label' indeterminate disabled />
       </div>
     );
   },
@@ -90,7 +90,7 @@ export const Disabled: Story = {
         disable: true
       }
     },
-    intermediate: {
+    indeterminate: {
       table: {
         disable: true
       }
@@ -98,7 +98,7 @@ export const Disabled: Story = {
   }
 };
 
-export const Intermediate: Story = {
+export const Indeterminate: Story = {
   render: (args) => {
     const [checked1, setChecked1] = React.useState<boolean>(true);
     const [checked2, setChecked2] = React.useState<boolean>(false);
@@ -115,7 +115,7 @@ export const Intermediate: Story = {
 
     return (
       <>
-        <FuiCheckbox {...args} checked={checked1 && checked2} intermediate={checked1 || checked2} onToggle={onToggleMaster} />
+        <FuiCheckbox {...args} checked={checked1 && checked2} indeterminate={checked1 || checked2} onToggle={onToggleMaster} />
         <div style={{ marginLeft: 'var(--fui-space-xxlg)', display: 'flex', flexDirection: 'column', gap: 'var(--fui-space-md)' }}>
           <FuiCheckbox {...args} checked={checked1} onToggle={setChecked1} />
           <FuiCheckbox {...args} checked={checked2} onToggle={setChecked2} />
@@ -131,7 +131,7 @@ export const Intermediate: Story = {
       url: 'https://www.figma.com/file/zHutj6e9DcPngHZTDtAL1u/Functional-UI-Kit?type=design&node-id=2461-15326'
     }
   },
-  name: 'Intermediate',
+  name: 'Indeterminate',
   argTypes: {
     disabled: {
       table: {
@@ -143,7 +143,7 @@ export const Intermediate: Story = {
         disable: true
       }
     },
-    intermediate: {
+    indeterminate: {
       table: {
         disable: true
       }
diff --git a/src/components/fui-checkbox/fui-checkbox.tsx b/src/components/fui-checkbox/fui-checkbox.tsx
index 9af3599..d797065 100644
--- a/src/components/fui-checkbox/fui-checkbox.tsx
+++ b/src/components/fui-checkbox/fui-checkbox.tsx
@@ -2,13 +2,13 @@ import React from 'react';
 import { prefix } from '../prefix';
 import FuiIconCheck12X12 from '../../icons/fui-icon-check-12x12';
 import classnames from 'classnames';
-import FuiIconIntermediateLine2x10 from '../../icons/fui-icon-intermediate-line-2x10';
+import FuiIconIndeterminateLine2x10 from '../../icons/fui-icon-indeterminate-line-2x10';
 
 const compPrefix = `${prefix}-checkbox`;
 
 export interface FuiCheckboxProps {
   checked?: boolean
-  intermediate?: boolean
+  indeterminate?: boolean
   disabled?: boolean
   onToggle: (isChecked: boolean) => void
   checkLabel?: string
@@ -22,7 +22,7 @@ export const FuiCheckbox = (props: FuiCheckboxProps) => {
     `${compPrefix}-wrapper`,
     props.disabled ? `${prefix}-disabled` : `${prefix}-interactable`,
     props.className,
-    (props.checked || props.intermediate) ? 'checked' : ''
+    (props.checked || props.indeterminate) ? 'checked' : ''
   );
 
   const onClick = (e: React.MouseEvent<HTMLDivElement>) => {
@@ -41,7 +41,7 @@ export const FuiCheckbox = (props: FuiCheckboxProps) => {
   return (
     <div aria-label={props.ariaLabel} tabIndex={0} onKeyDown={onSpace} className={classNames} onClick={onClick}>
       <div role='checkbox' className={compPrefix} >
-        {props.checked ? <FuiIconCheck12X12 /> : props.intermediate ? <FuiIconIntermediateLine2x10 /> : null}
+        {props.checked ? <FuiIconCheck12X12 /> : props.indeterminate ? <FuiIconIndeterminateLine2x10 /> : null}
       </div>
       {props.checkLabel && <label>{props.checkLabel}</label>}
     </div>
diff --git a/src/components/fui-radio/fui-radio.tsx b/src/components/fui-radio/fui-radio.tsx
index f9ea1e8..c37e540 100644
--- a/src/components/fui-radio/fui-radio.tsx
+++ b/src/components/fui-radio/fui-radio.tsx
@@ -17,6 +17,9 @@ const compPrefix = `${prefix}-radio`;
 export const FuiRadio = (props: FuiRadioProps) => {
   const [focused, setFocused] = React.useState(false);
   const ref = React.useRef<HTMLInputElement>(null);
+  const inputId = React.useMemo(() => `${compPrefix}-input-${Math.random().toString(36).substring(7)}`, []);
+  const labelId = React.useMemo(() => `${compPrefix}-label-${Math.random().toString(36).substring(7)}`, []);
+
   const indicatorClassNames = classnames(
     `${compPrefix}-indicator`,
     props.className,
@@ -48,11 +51,11 @@ export const FuiRadio = (props: FuiRadioProps) => {
   return (
     <div aria-label={props.ariaLabel} role='radio' className={classNames} onClick={onClick}>
       <div role='radio' className={indicatorClassNames} onClick={onClick}>
-        <input onKeyDown={onSpace} onBlur={() => { setFocused(false); }} onFocus={() => { setFocused(true); }} disabled={props.disabled} onChange={props.onClick} ref={ref} type='radio' style={{ height: 0 }} />
+        <input id={inputId} aria-labelledby={labelId} onKeyDown={onSpace} onBlur={() => { setFocused(false); }} onFocus={() => { setFocused(true); }} disabled={props.disabled} onChange={props.onClick} ref={ref} type='radio' style={{ height: 0 }} />
       </div>
-      {props.label && <span className={`${compPrefix}-label`}>
+      {props.label && <label id={labelId} htmlFor={inputId} className={`${compPrefix}-label`}>
         {props.label}
-      </span>}
+      </label>}
     </div>
   );
 };
diff --git a/src/components/fui-stepper/fui-stepper.tsx b/src/components/fui-stepper/fui-stepper.tsx
index c66392b..00f2367 100644
--- a/src/components/fui-stepper/fui-stepper.tsx
+++ b/src/components/fui-stepper/fui-stepper.tsx
@@ -25,6 +25,9 @@ export interface FuiStepperProps {
 }
 
 export const FuiStepper = (props: FuiStepperProps) => {
+  const inputId = React.useMemo(() => `${compPrefix}-input-${Math.random().toString(36).substring(7)}`, []);
+  const labelId = React.useMemo(() => `${compPrefix}-label-${Math.random().toString(36).substring(7)}`, []);
+
   const isIncDisabled = React.useMemo(() => {
     return props.disabled && [FuiStepperDisabled.All, FuiStepperDisabled.Plus].includes(props.disabled);
   }, [props.disabled]);
@@ -73,14 +76,14 @@ export const FuiStepper = (props: FuiStepperProps) => {
 
   return (
     <div className={classNames}>
-      {props.label && <div className={`${compPrefix}-label`}>{props.label}</div>}
+      {props.label && <label id={labelId} htmlFor={inputId} className={`${compPrefix}-label`}>{props.label}</label>}
       {props.status && <FuiStatusMessage {...props.status} />}
       <div className={`${compPrefix}-container`} style={containerStyle}>
         <button onClick={dec} className={minusButtonClassNames} disabled={isDecDisabled}>
           <FuiIconMinus12x12 />
         </button>
         <div className={valueContainerClassNames}>
-          <input type="number" className={`${compPrefix}-input`} value={props.value} onChange={(e) => { props.onChange(Number(e.target.value)); }} disabled={isAllDisabled} />
+          <input id={inputId} aria-labelledby={labelId} type="number" className={`${compPrefix}-input`} value={props.value} onChange={(e) => { props.onChange(Number(e.target.value)); }} disabled={isAllDisabled} />
         </div>
         <button onClick={inc} className={plusButtonClassNames} disabled={isIncDisabled}>
           <FuiIconPlus12x12 />
diff --git a/src/components/fui-text-input/fui-text-input.tsx b/src/components/fui-text-input/fui-text-input.tsx
index e3452dc..4beef4f 100644
--- a/src/components/fui-text-input/fui-text-input.tsx
+++ b/src/components/fui-text-input/fui-text-input.tsx
@@ -25,6 +25,8 @@ export interface FuiTextInputProps {
 
 export const FuiTextInput = (props: FuiTextInputProps) => {
   const [isActive, setIsActive] = React.useState(false);
+  const inputId = React.useMemo(() => `${compPrefix}-input-${Math.random().toString(36).substring(7)}`, []);
+  const labelId = React.useMemo(() => `${compPrefix}-label-${Math.random().toString(36).substring(7)}`, []);
 
   const clearValue = React.useCallback(() => {
     props.onChange('');
@@ -40,14 +42,17 @@ export const FuiTextInput = (props: FuiTextInputProps) => {
     }
   );
 
+
   return (
     <div className={`${compPrefix}-wrapper ${props.className}`}>
-      {props.label ? <div className={`${compPrefix}-label`}>{props.label}</div> : null}
+      {props.label ? <label id={labelId} htmlFor={inputId} className={`${compPrefix}-label`}>{props.label}</label> : null}
       {props.status ? <FuiStatusMessage {...props.status} /> : null}
       <div className={`${compPrefix}-container ${props.disabled ? `${prefix}-disabled` : ''}`}>
         {props.prefix ? <div className={`${compPrefix}-prefix`}>{props.prefix}</div> : null}
         <div className={inputContainerClassNames}>
           <input
+            id={inputId}
+            aria-labelledby={labelId}
             aria-label={props.ariaLabel}
             type="text"
             value={props.value}
diff --git a/src/components/fui-toggle/fui-toggle.tsx b/src/components/fui-toggle/fui-toggle.tsx
index 7456f07..1e2b9d1 100644
--- a/src/components/fui-toggle/fui-toggle.tsx
+++ b/src/components/fui-toggle/fui-toggle.tsx
@@ -44,7 +44,7 @@ export const FuiToggle = (props: FuiToggleProps) => {
 
   return (
     <fieldset aria-label={props.ariaLabel} className={classNames}>
-      <div className={`${compPrefix}-active-bg`} style={{ width: `${activeTabWidth}px`, left: `${activeTabLeftLocation}px` }}/>
+      <div className={`${compPrefix}-active-bg`} style={{ width: `${activeTabWidth}px`, left: `${activeTabLeftLocation}px` }} />
       {props.options.map((option) => {
         const onChange = () => {
           if (props.disabled) return;
diff --git a/src/icons/fui-icon-intermediate-line-2x10.tsx b/src/icons/fui-icon-indeterminate-line-2x10.tsx
similarity index 56%
rename from src/icons/fui-icon-intermediate-line-2x10.tsx
rename to src/icons/fui-icon-indeterminate-line-2x10.tsx
index 2bc8bdb..a213462 100644
--- a/src/icons/fui-icon-intermediate-line-2x10.tsx
+++ b/src/icons/fui-icon-indeterminate-line-2x10.tsx
@@ -1,9 +1,9 @@
 import React from 'react';
 import { prefix } from '../components/prefix';
 
-export default function FuiIconIntermediateLine2x10 () {
+export default function FuiIconIndeterminateLine2x10 () {
   return (
-    <svg className={`${prefix}-icon-intermediate-line-2x10`} width="18" height="18" viewBox="0 0 18 18" xmlns="http://www.w3.org/2000/svg">
+    <svg className={`${prefix}-icon-indeterminate-line-2x10`} width="18" height="18" viewBox="0 0 18 18" xmlns="http://www.w3.org/2000/svg">
       <path d="M4 9C4 8.44772 4.44772 8 5 8H13C13.5523 8 14 8.44772 14 9C14 9.55228 13.5523 10 13 10H5C4.44772 10 4 9.55228 4 9Z" fill="currentcolor" />
     </svg>
   );
diff --git a/src/icons/icons.stories.tsx b/src/icons/icons.stories.tsx
index 52ebaf0..e722963 100644
--- a/src/icons/icons.stories.tsx
+++ b/src/icons/icons.stories.tsx
@@ -11,7 +11,7 @@ import FuiIconPlaceholder32X32 from './fui-icon-placeholder-32x32';
 import FuiIconX12x12 from './fui-icon-x-12x12';
 import FuiIconX8x8 from './fui-icon-x-8x8';
 import FuiIconX16x16 from './fui-icon-x-16x16';
-import FuiIconIntermediateLine2x10 from './fui-icon-intermediate-line-2x10';
+import FuiIconIndeterminateLine2x10 from './fui-icon-indeterminate-line-2x10';
 
 const meta = {
   title: ' Components/Icons'
@@ -31,4 +31,4 @@ export const Placeholder32X32: Story = { render: () => <FuiIconPlaceholder32X32/
 export const X8x8: Story = { render: () => <FuiIconX8x8/> };
 export const X12x12: Story = { render: () => <FuiIconX12x12/> };
 export const X16x16: Story = { render: () => <FuiIconX16x16/> };
-export const IntermediateLine2x10: Story = { render: () => <FuiIconIntermediateLine2x10/> };
+export const IndeterminateLine2x10: Story = { render: () => <FuiIconIndeterminateLine2x10/> };

From b66d486d17f420a2bb76dc2f00d8a9ad4c861e78 Mon Sep 17 00:00:00 2001
From: Almog Adziashvili <almoga@wix.com>
Date: Sun, 10 Mar 2024 15:28:31 +0200
Subject: [PATCH 2/2] add homepage

---
 package.json | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package.json b/package.json
index 3f2ef56..33748da 100644
--- a/package.json
+++ b/package.json
@@ -2,6 +2,7 @@
   "name": "functional-ui-kit",
   "version": "1.0.0",
   "description": "Functional UI Kit",
+  "homepage": "https://functional-ui-kit.com/",
   "scripts": {
     "build": "vite build --config vite.config.ts",
     "dev": "npm run storybook",