Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register serverless as peer dependency #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

medikoo
Copy link

@medikoo medikoo commented Jul 14, 2021

It's to ensure only compatible versions or Framework are used together with a plugin, and if mismatch occurs, user is informed with meaningful error message.

This PR is part of Serverless Framework initiative to curate most popular plugins

@andersquist
Copy link
Collaborator

andersquist commented Jul 16, 2021

There seems to be some issues with Travis CI for this repo starting about a month ago - every request for a build is returning "Could not authorize build request for functionalone/serverless-iam-roles-per-function." when looking in Travis.

There is no obvious reason to why this is happening but googling it suggests it might be due to the requirement to chose a free plan for the repo but it feels a bit strange. Don't have access to chose a plan so I can't remedy either way.

My cents here would be to suggest that we migrate the build to Git Actions in favor of Travis.

@medikoo
Copy link
Author

medikoo commented Jul 16, 2021

@andersquist @Enase we have some good templates for GA flow. https://github.com/serverless/template-package/tree/master/.github/workflows

I may help with that if needed

@Enase
Copy link
Collaborator

Enase commented Jul 19, 2021

We definitely have some troubles with travis. It shouldn't take a long time to fix it, but unfortunately I don't have access to travis and project settings.

@Enase
Copy link
Collaborator

Enase commented Jul 19, 2021

@glicht is the only person I know who can fix the issue.

@medikoo
Copy link
Author

medikoo commented Jul 19, 2021

@glicht is there any chance we can get help on adjusting this repository settings?

@medikoo medikoo force-pushed the 0714-register-serverless-peer branch from e4df3cb to 756fb3c Compare November 25, 2021 09:34
@andersquist
Copy link
Collaborator

FYI: Since this repo has gotten stuck in terms of being able to release new versions of the package I've setup a fork that releases it using a slightly different package name serverless-iamroles for now:
https://github.com/andersquist/serverless-iam-roles-per-function

I'll incorporate this PR there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants