New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow `TNone.value` field type to never #125

Merged
merged 1 commit into from Jun 22, 2018

Conversation

Projects
None yet
3 participants
@mcastellini
Contributor

mcastellini commented Mar 28, 2018

Fixes #122

@codecov

This comment has been minimized.

codecov bot commented Mar 28, 2018

Codecov Report

Merging #125 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #125   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          17     17           
  Lines        2197   2197           
  Branches      422    422           
=====================================
  Hits         2197   2197
Impacted Files Coverage Δ
packages/funfix-core/src/disjunctions.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a322789...eba7eff. Read the comment docs.

@alexandru

This comment has been minimized.

Member

alexandru commented Jun 22, 2018

Sorry @mcastellini for the delay in my response.

I've been really busy with other projects, work and life in general 🙂 and Funfix has been a low priority lately. I intend to get back on track with it.

Merging this now and I'll do a new release soon.

Cheers,

@alexandru alexandru merged commit 0c315b6 into funfix:master Jun 22, 2018

3 checks passed

codecov/patch Coverage not affected when comparing a322789...eba7eff
Details
codecov/project 100% remains the same compared to a322789
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tbinna

This comment has been minimized.

tbinna commented Oct 23, 2018

@alexandru do you have time to push a release that includes this?

I am using funfix 7.0.1 and affected by this. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment