Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] viz_surface #42

Merged
merged 5 commits into from Jan 3, 2019

Conversation

Projects
None yet
4 participants
@skoudoro
Copy link
Contributor

commented Dec 19, 2018

The goal of this PR is to fix the Travis issue here

I use this opportunity to move the io module from DIPY.

@pep8speaks

This comment has been minimized.

Copy link

commented Dec 19, 2018

Hello @skoudoro! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on December 28, 2018 at 19:31 Hours UTC
@codecov

This comment has been minimized.

Copy link

commented Dec 19, 2018

Codecov Report

Merging #42 into master will increase coverage by 0.02%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   81.03%   81.05%   +0.02%     
==========================================
  Files          12       13       +1     
  Lines        3011     3062      +51     
  Branches      333      349      +16     
==========================================
+ Hits         2440     2482      +42     
- Misses        470      476       +6     
- Partials      101      104       +3
Impacted Files Coverage Δ
fury/io.py 82.35% <82.35%> (ø)
vtk, have_vtk, setup_module = optional_package('vtk')
from fury.io import save_polydata, load_polydata
from fury import window, utils
from fury.utils import vtk

This comment has been minimized.

Copy link
@dmreagan

dmreagan Dec 20, 2018

Contributor

Sort imports

from fury import utils, window
from fury.io import load_polydata, save_polydata
from fury.utils import vtk
fury/io.py Outdated

reader.SetFileName(file_name)
reader.Update()
# print(file_name + " Mesh " + file_extension + " Loaded")

This comment has been minimized.

Copy link
@dmreagan

dmreagan Dec 20, 2018

Contributor

Remove commented line

fury/io.py Outdated
elif file_extension == "xml":
writer = vtk.vtkXMLPolyDataWriter()
elif file_extension == "obj":
raise Exception("mni obj or Wavefront obj ?")

This comment has been minimized.

Copy link
@dmreagan

dmreagan Dec 20, 2018

Contributor

This exception asks the user to clarify which version of obj, but gives them no options for how to do so. All objs raise the exception.

skoudoro added some commits Dec 28, 2018

@skoudoro

This comment has been minimized.

Copy link
Contributor Author

commented Jan 2, 2019

This PR is ready to be merged, can you have a look @dmreagan @Garyfallidis

@Garyfallidis

This comment has been minimized.

Copy link
Contributor

commented Jan 3, 2019

:)

@Garyfallidis Garyfallidis merged commit 1b6508a into fury-gl:master Jan 3, 2019

3 checks passed

codecov/patch 82.35% of diff hit (target 81.03%)
Details
codecov/project 81.05% (+0.02%) compared to f12b691
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:fix-example branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.